linux-kernel - Re: [PATCH 6/6] vfio: do not set FMODE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <YrbpBoYR7cSYlLR9@zx2c4.com>
Date:   Sat, 25 Jun 2022 12:52:54 +0200
From:   "Jason A. Donenfeld" <Jason@...c4.com>
To:     Al Viro <viro@...iv.linux.org.uk>
Cc:     linux-kernel@...r.kernel.org, Jens Axboe <axboe@...nel.dk>,
        linux-fsdevel@...r.kernel.org,
        Alex Williamson <alex.williamson@...hat.com>,
        Cornelia Huck <cohuck@...hat.com>, kvm@...r.kernel.org
Subject: Re: [PATCH 6/6] vfio: do not set FMODE_LSEEK flag

On Fri, Jun 24, 2022 at 10:53:19PM +0100, Al Viro wrote:
> On Fri, Jun 24, 2022 at 06:56:31PM +0200, Jason A. Donenfeld wrote:
> > This file does not support llseek, so don't set the flag advertising it.
> 
> ... or it could grow a working llseek - doesn't look like it would be
> hard to do...

I started doing this, but it looks somewhat involved and a bit out of
scope here. vfio_device_ops would need to grow a new member, and then
the various types of vfio devices would need to start using it and so
forth. I'll save that for another series.

Jason