linux-kernel - Re: [PATCH] iio: Don't use bare "unsigned"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Sat, 25 Jun 2022 12:17:05 +0100
From:   Jonathan Cameron <jic23@...nel.org>
To:     Joe Simmons-Talbott <joetalbott@...il.com>
Cc:     lars@...afoo.de, linux-iio@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] iio: Don't use bare "unsigned"

On Thu, 23 Jun 2022 22:18:06 -0400
Joe Simmons-Talbott <joetalbott@...il.com> wrote:

> Use "unsigned int" rather than bare "unsigned". Reported by checkpatch.pl.
> 
> Signed-off-by: Joe Simmons-Talbott <joetalbott@...il.com>

I've always wondered when someone would get around to tidying this up.
Never seemed worth the effort to do it myself :)

Anyhow, thanks.  Applied to the togreg branch of iio.git.

Thanks,

Jonathan

> ---
>  drivers/iio/industrialio-buffer.c     | 10 +++++-----
>  drivers/iio/industrialio-core.c       |  4 ++--
>  drivers/iio/industrialio-sw-device.c  |  2 +-
>  drivers/iio/industrialio-sw-trigger.c |  2 +-
>  4 files changed, 9 insertions(+), 9 deletions(-)
> 
> diff --git a/drivers/iio/industrialio-buffer.c b/drivers/iio/industrialio-buffer.c
> index b078eb2f3c9d..513a34a0b593 100644
> --- a/drivers/iio/industrialio-buffer.c
> +++ b/drivers/iio/industrialio-buffer.c
> @@ -705,7 +705,7 @@ static unsigned int iio_storage_bytes_for_timestamp(struct iio_dev *indio_dev)
>  static int iio_compute_scan_bytes(struct iio_dev *indio_dev,
>  				const unsigned long *mask, bool timestamp)
>  {
> -	unsigned bytes = 0;
> +	unsigned int bytes = 0;
>  	int length, i, largest = 0;
>  
>  	/* How much space will the demuxed element take? */
> @@ -934,9 +934,9 @@ static int iio_verify_update(struct iio_dev *indio_dev,
>   * @l:		list head used for management
>   */
>  struct iio_demux_table {
> -	unsigned from;
> -	unsigned to;
> -	unsigned length;
> +	unsigned int from;
> +	unsigned int to;
> +	unsigned int length;
>  	struct list_head l;
>  };
>  
> @@ -974,7 +974,7 @@ static int iio_buffer_update_demux(struct iio_dev *indio_dev,
>  				   struct iio_buffer *buffer)
>  {
>  	int ret, in_ind = -1, out_ind, length;
> -	unsigned in_loc = 0, out_loc = 0;
> +	unsigned int in_loc = 0, out_loc = 0;
>  	struct iio_demux_table *p = NULL;
>  
>  	/* Clear out any old demux */
> diff --git a/drivers/iio/industrialio-core.c b/drivers/iio/industrialio-core.c
> index e1ed44dec2ab..ca28f76b8f40 100644
> --- a/drivers/iio/industrialio-core.c
> +++ b/drivers/iio/industrialio-core.c
> @@ -384,7 +384,7 @@ static ssize_t iio_debugfs_read_reg(struct file *file, char __user *userbuf,
>  {
>  	struct iio_dev *indio_dev = file->private_data;
>  	struct iio_dev_opaque *iio_dev_opaque = to_iio_dev_opaque(indio_dev);
> -	unsigned val = 0;
> +	unsigned int val = 0;
>  	int ret;
>  
>  	if (*ppos > 0)
> @@ -414,7 +414,7 @@ static ssize_t iio_debugfs_write_reg(struct file *file,
>  {
>  	struct iio_dev *indio_dev = file->private_data;
>  	struct iio_dev_opaque *iio_dev_opaque = to_iio_dev_opaque(indio_dev);
> -	unsigned reg, val;
> +	unsigned int reg, val;
>  	char buf[80];
>  	int ret;
>  
> diff --git a/drivers/iio/industrialio-sw-device.c b/drivers/iio/industrialio-sw-device.c
> index 49f775f16ad5..cdaf30a3f233 100644
> --- a/drivers/iio/industrialio-sw-device.c
> +++ b/drivers/iio/industrialio-sw-device.c
> @@ -27,7 +27,7 @@ static DEFINE_MUTEX(iio_device_types_lock);
>  
>  static
>  struct iio_sw_device_type *__iio_find_sw_device_type(const char *name,
> -						     unsigned len)
> +						     unsigned int len)
>  {
>  	struct iio_sw_device_type *d = NULL, *iter;
>  
> diff --git a/drivers/iio/industrialio-sw-trigger.c b/drivers/iio/industrialio-sw-trigger.c
> index 9ae793a70b8b..994f03a71520 100644
> --- a/drivers/iio/industrialio-sw-trigger.c
> +++ b/drivers/iio/industrialio-sw-trigger.c
> @@ -27,7 +27,7 @@ static DEFINE_MUTEX(iio_trigger_types_lock);
>  
>  static
>  struct iio_sw_trigger_type *__iio_find_sw_trigger_type(const char *name,
> -						       unsigned len)
> +						       unsigned int len)
>  {
>  	struct iio_sw_trigger_type *t = NULL, *iter;
>