linux-kernel - Re: [PATCH] iio: dac: ad5380: aligned '*' each line and drop unneeded blank line

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Sat, 25 Jun 2022 14:26:32 +0100
From:   Jonathan Cameron <jic23@...nel.org>
To:     Andy Shevchenko <andy.shevchenko@...il.com>
Cc:     Jiang Jian <jiangjian@...rlc.com>,
        Lars-Peter Clausen <lars@...afoo.de>,
        Michael Hennerich <Michael.Hennerich@...log.com>,
        linux-iio <linux-iio@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] iio: dac: ad5380: aligned '*' each line and drop
 unneeded blank line

On Tue, 21 Jun 2022 16:08:14 +0200
Andy Shevchenko <andy.shevchenko@...il.com> wrote:

> On Tue, Jun 21, 2022 at 11:26 AM Jiang Jian <jiangjian@...rlc.com> wrote:
> >
> > Consider '*' alignment in the comments of struct ad5380_chip_info declaration.  
> 
> Next time don't forget to bump the version of the patch (use -vX, X =
> 0,1, ..., with the `git format-patch`) and add a changelog (after
> cutter '---' line).
> 
> > ...  
> > >   * @channel_template:  channel specification template
> > >   * @num_channels:      number of channels
> > >   * @int_vref:          internal vref in uV
> > > -*/
> > > + */
> > >  
> > While at it, drop the unneeded blank line here.  
> > >  struct ad5380_chip_info {  
> > ...
> > }  
> 
> This should be replaced by something simpler, like:
> While at it, drop the unneeded blank lines.
> 
> Reviewed-by: Andy Shevchenko <andy.shevchenko@...il.com>
> 
> I do not think you need to resend this simplest patch and Jonathan
> will help you this time, but consider the above for future
> contributions, thanks!
Tweaked and applied to the togreg branch of iio.git which I'll
push out initially as testing to let the 0-day bot poke it.

Thanks,

Jonathan

> 
> > Signed-off-by: Jiang Jian <jiangjian@...rlc.com>
> > ---
> >  drivers/iio/dac/ad5380.c | 4 +---
> >  1 file changed, 1 insertion(+), 3 deletions(-)
> >
> > diff --git a/drivers/iio/dac/ad5380.c b/drivers/iio/dac/ad5380.c
> > index a44c83242fb1..81775152aac6 100644
> > --- a/drivers/iio/dac/ad5380.c
> > +++ b/drivers/iio/dac/ad5380.c
> > @@ -36,8 +36,7 @@
> >   * @channel_template:  channel specification template
> >   * @num_channels:      number of channels
> >   * @int_vref:          internal vref in uV
> > -*/
> > -
> > + */
> >  struct ad5380_chip_info {
> >         struct iio_chan_spec    channel_template;
> >         unsigned int            num_channels;
> > @@ -53,7 +52,6 @@ struct ad5380_chip_info {
> >   * @pwr_down:          whether the chip is currently in power down mode
> >   * @lock:              lock to protect the data buffer during regmap ops
> >   */
> > -
> >  struct ad5380_state {
> >         struct regmap                   *regmap;
> >         const struct ad5380_chip_info   *chip_info;
> > --
> > 2.17.1
> >  
> 
> 
> --
> With Best Regards,
> Andy Shevchenko