lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [day] [month] [year] [list]
Message-ID: <202206252135.7VbdJEIx-lkp@intel.com>
Date:   Sat, 25 Jun 2022 21:19:30 +0800
From:   kernel test robot <lkp@...el.com>
To:     Tong Tiangen <tongtiangen@...wei.com>
Cc:     llvm@...ts.linux.dev, kbuild-all@...ts.01.org,
        linux-kernel@...r.kernel.org,
        Andrew Morton <akpm@...ux-foundation.org>,
        Linux Memory Management List <linux-mm@...ck.org>,
        Pasha Tatashin <pasha.tatashin@...een.com>
Subject: mm/page_table_check.c:148:6: error: call to undeclared function
 'pte_user_accessible_page'; ISO C99 and later do not support implicit
 function declarations

Hi Tong,

FYI, the error/warning still remains.

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head:   8c23f235a6a8ae43abea215812eb9d8cf4dd165e
commit: 3fee229a8eb936b96933c6b2cd02d2e87a4cc997 riscv/mm: enable ARCH_SUPPORTS_PAGE_TABLE_CHECK
date:   6 weeks ago
config: riscv-randconfig-r003-20220625
compiler: clang version 15.0.0 (https://github.com/llvm/llvm-project 42a7ddb428c999229491b0effbb1a4059149fba8)
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # install riscv cross compiling tool for clang build
        # apt-get install binutils-riscv64-linux-gnu
        # https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=3fee229a8eb936b96933c6b2cd02d2e87a4cc997
        git remote add linus https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
        git fetch --no-tags linus master
        git checkout 3fee229a8eb936b96933c6b2cd02d2e87a4cc997
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=riscv SHELL=/bin/bash

If you fix the issue, kindly add following tag where applicable
Reported-by: kernel test robot <lkp@...el.com>

All errors (new ones prefixed by >>):

>> mm/page_table_check.c:148:6: error: call to undeclared function 'pte_user_accessible_page'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
           if (pte_user_accessible_page(pte)) {
               ^
>> mm/page_table_check.c:149:36: error: call to undeclared function 'pte_pfn'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
                   page_table_check_clear(mm, addr, pte_pfn(pte),
                                                    ^
>> mm/page_table_check.c:161:6: error: call to undeclared function 'pmd_user_accessible_page'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
           if (pmd_user_accessible_page(pmd)) {
               ^
>> mm/page_table_check.c:162:36: error: call to undeclared function 'pmd_pfn'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
                   page_table_check_clear(mm, addr, pmd_pfn(pmd),
                                                    ^
   mm/page_table_check.c:162:36: note: did you mean '_pmd_pfn'?
   arch/riscv/include/asm/pgtable-64.h:144:29: note: '_pmd_pfn' declared here
   static inline unsigned long _pmd_pfn(pmd_t pmd)
                               ^
>> mm/page_table_check.c:174:6: error: call to undeclared function 'pud_user_accessible_page'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
           if (pud_user_accessible_page(pud)) {
               ^
>> mm/page_table_check.c:175:36: error: call to undeclared function 'pud_pfn'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
                   page_table_check_clear(mm, addr, pud_pfn(pud),
                                                    ^
   mm/page_table_check.c:175:36: note: did you mean '_pud_pfn'?
   arch/riscv/include/asm/pgtable-64.h:104:29: note: '_pud_pfn' declared here
   static inline unsigned long _pud_pfn(pud_t pud)
                               ^
   mm/page_table_check.c:188:6: error: call to undeclared function 'pte_user_accessible_page'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
           if (pte_user_accessible_page(pte)) {
               ^
   mm/page_table_check.c:189:34: error: call to undeclared function 'pte_pfn'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
                   page_table_check_set(mm, addr, pte_pfn(pte),
                                                  ^
>> mm/page_table_check.c:191:10: error: call to undeclared function 'pte_write'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
                                        pte_write(pte));
                                        ^
   mm/page_table_check.c:203:6: error: call to undeclared function 'pmd_user_accessible_page'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
           if (pmd_user_accessible_page(pmd)) {
               ^
   mm/page_table_check.c:204:34: error: call to undeclared function 'pmd_pfn'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
                   page_table_check_set(mm, addr, pmd_pfn(pmd),
                                                  ^
>> mm/page_table_check.c:206:10: error: call to undeclared function 'pmd_write'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
                                        pmd_write(pmd));
                                        ^
   mm/page_table_check.c:218:6: error: call to undeclared function 'pud_user_accessible_page'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
           if (pud_user_accessible_page(pud)) {
               ^
   mm/page_table_check.c:219:34: error: call to undeclared function 'pud_pfn'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
                   page_table_check_set(mm, addr, pud_pfn(pud),
                                                  ^
>> mm/page_table_check.c:221:10: error: call to undeclared function 'pud_write'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
                                        pud_write(pud));
                                        ^
   mm/page_table_check.c:221:10: note: did you mean 'up_write'?
   include/linux/rwsem.h:202:13: note: 'up_write' declared here
   extern void up_write(struct rw_semaphore *sem);
               ^
>> mm/page_table_check.c:233:7: error: call to undeclared function 'pmd_bad'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
           if (!pmd_bad(pmd) && !pmd_leaf(pmd)) {
                ^
>> mm/page_table_check.c:234:17: error: call to undeclared function 'pte_offset_map'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
                   pte_t *ptep = pte_offset_map(&pmd, addr);
                                 ^
   mm/page_table_check.c:234:10: warning: incompatible integer to pointer conversion initializing 'pte_t *' with an expression of type 'int' [-Wint-conversion]
                   pte_t *ptep = pte_offset_map(&pmd, addr);
                          ^      ~~~~~~~~~~~~~~~~~~~~~~~~~~
>> mm/page_table_check.c:237:3: error: call to undeclared function 'pte_unmap'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
                   pte_unmap(ptep);
                   ^
   mm/page_table_check.c:237:3: note: did you mean 'pte_devmap'?
   include/linux/mm.h:2113:19: note: 'pte_devmap' declared here
   static inline int pte_devmap(pte_t pte)
                     ^
>> mm/page_table_check.c:238:19: error: use of undeclared identifier 'PTRS_PER_PTE'
                   for (i = 0; i < PTRS_PER_PTE; i++) {
                                   ^
   1 warning and 19 errors generated.

Kconfig warnings: (for reference only)
   WARNING: unmet direct dependencies detected for DRM_TTM
   Depends on HAS_IOMEM && DRM && MMU
   Selected by
   - DRM_TTM_HELPER && HAS_IOMEM && DRM
   - DRM_HISI_HIBMC && HAS_IOMEM && DRM && PCI && (ARM64 || COMPILE_TEST


vim +/pte_user_accessible_page +148 mm/page_table_check.c

df4e817b710809 Pasha Tatashin 2022-01-14  141  
df4e817b710809 Pasha Tatashin 2022-01-14  142  void __page_table_check_pte_clear(struct mm_struct *mm, unsigned long addr,
df4e817b710809 Pasha Tatashin 2022-01-14  143  				  pte_t pte)
df4e817b710809 Pasha Tatashin 2022-01-14  144  {
df4e817b710809 Pasha Tatashin 2022-01-14  145  	if (&init_mm == mm)
df4e817b710809 Pasha Tatashin 2022-01-14  146  		return;
df4e817b710809 Pasha Tatashin 2022-01-14  147  
df4e817b710809 Pasha Tatashin 2022-01-14 @148  	if (pte_user_accessible_page(pte)) {
df4e817b710809 Pasha Tatashin 2022-01-14 @149  		page_table_check_clear(mm, addr, pte_pfn(pte),
df4e817b710809 Pasha Tatashin 2022-01-14  150  				       PAGE_SIZE >> PAGE_SHIFT);
df4e817b710809 Pasha Tatashin 2022-01-14  151  	}
df4e817b710809 Pasha Tatashin 2022-01-14  152  }
df4e817b710809 Pasha Tatashin 2022-01-14  153  EXPORT_SYMBOL(__page_table_check_pte_clear);
df4e817b710809 Pasha Tatashin 2022-01-14  154  
df4e817b710809 Pasha Tatashin 2022-01-14  155  void __page_table_check_pmd_clear(struct mm_struct *mm, unsigned long addr,
df4e817b710809 Pasha Tatashin 2022-01-14  156  				  pmd_t pmd)
df4e817b710809 Pasha Tatashin 2022-01-14  157  {
df4e817b710809 Pasha Tatashin 2022-01-14  158  	if (&init_mm == mm)
df4e817b710809 Pasha Tatashin 2022-01-14  159  		return;
df4e817b710809 Pasha Tatashin 2022-01-14  160  
df4e817b710809 Pasha Tatashin 2022-01-14 @161  	if (pmd_user_accessible_page(pmd)) {
df4e817b710809 Pasha Tatashin 2022-01-14 @162  		page_table_check_clear(mm, addr, pmd_pfn(pmd),
92fb05242a1b1e Tong Tiangen   2022-05-12  163  				       PMD_SIZE >> PAGE_SHIFT);
df4e817b710809 Pasha Tatashin 2022-01-14  164  	}
df4e817b710809 Pasha Tatashin 2022-01-14  165  }
df4e817b710809 Pasha Tatashin 2022-01-14  166  EXPORT_SYMBOL(__page_table_check_pmd_clear);
df4e817b710809 Pasha Tatashin 2022-01-14  167  
df4e817b710809 Pasha Tatashin 2022-01-14  168  void __page_table_check_pud_clear(struct mm_struct *mm, unsigned long addr,
df4e817b710809 Pasha Tatashin 2022-01-14  169  				  pud_t pud)
df4e817b710809 Pasha Tatashin 2022-01-14  170  {
df4e817b710809 Pasha Tatashin 2022-01-14  171  	if (&init_mm == mm)
df4e817b710809 Pasha Tatashin 2022-01-14  172  		return;
df4e817b710809 Pasha Tatashin 2022-01-14  173  
df4e817b710809 Pasha Tatashin 2022-01-14 @174  	if (pud_user_accessible_page(pud)) {
df4e817b710809 Pasha Tatashin 2022-01-14 @175  		page_table_check_clear(mm, addr, pud_pfn(pud),
92fb05242a1b1e Tong Tiangen   2022-05-12  176  				       PUD_SIZE >> PAGE_SHIFT);
df4e817b710809 Pasha Tatashin 2022-01-14  177  	}
df4e817b710809 Pasha Tatashin 2022-01-14  178  }
df4e817b710809 Pasha Tatashin 2022-01-14  179  EXPORT_SYMBOL(__page_table_check_pud_clear);
df4e817b710809 Pasha Tatashin 2022-01-14  180  
df4e817b710809 Pasha Tatashin 2022-01-14  181  void __page_table_check_pte_set(struct mm_struct *mm, unsigned long addr,
df4e817b710809 Pasha Tatashin 2022-01-14  182  				pte_t *ptep, pte_t pte)
df4e817b710809 Pasha Tatashin 2022-01-14  183  {
df4e817b710809 Pasha Tatashin 2022-01-14  184  	if (&init_mm == mm)
df4e817b710809 Pasha Tatashin 2022-01-14  185  		return;
df4e817b710809 Pasha Tatashin 2022-01-14  186  
64d8b9e14512ce Pasha Tatashin 2022-02-03  187  	__page_table_check_pte_clear(mm, addr, *ptep);
df4e817b710809 Pasha Tatashin 2022-01-14  188  	if (pte_user_accessible_page(pte)) {
df4e817b710809 Pasha Tatashin 2022-01-14  189  		page_table_check_set(mm, addr, pte_pfn(pte),
df4e817b710809 Pasha Tatashin 2022-01-14  190  				     PAGE_SIZE >> PAGE_SHIFT,
df4e817b710809 Pasha Tatashin 2022-01-14 @191  				     pte_write(pte));
df4e817b710809 Pasha Tatashin 2022-01-14  192  	}
df4e817b710809 Pasha Tatashin 2022-01-14  193  }
df4e817b710809 Pasha Tatashin 2022-01-14  194  EXPORT_SYMBOL(__page_table_check_pte_set);
df4e817b710809 Pasha Tatashin 2022-01-14  195  
df4e817b710809 Pasha Tatashin 2022-01-14  196  void __page_table_check_pmd_set(struct mm_struct *mm, unsigned long addr,
df4e817b710809 Pasha Tatashin 2022-01-14  197  				pmd_t *pmdp, pmd_t pmd)
df4e817b710809 Pasha Tatashin 2022-01-14  198  {
df4e817b710809 Pasha Tatashin 2022-01-14  199  	if (&init_mm == mm)
df4e817b710809 Pasha Tatashin 2022-01-14  200  		return;
df4e817b710809 Pasha Tatashin 2022-01-14  201  
64d8b9e14512ce Pasha Tatashin 2022-02-03  202  	__page_table_check_pmd_clear(mm, addr, *pmdp);
df4e817b710809 Pasha Tatashin 2022-01-14  203  	if (pmd_user_accessible_page(pmd)) {
df4e817b710809 Pasha Tatashin 2022-01-14  204  		page_table_check_set(mm, addr, pmd_pfn(pmd),
92fb05242a1b1e Tong Tiangen   2022-05-12  205  				     PMD_SIZE >> PAGE_SHIFT,
df4e817b710809 Pasha Tatashin 2022-01-14 @206  				     pmd_write(pmd));
df4e817b710809 Pasha Tatashin 2022-01-14  207  	}
df4e817b710809 Pasha Tatashin 2022-01-14  208  }
df4e817b710809 Pasha Tatashin 2022-01-14  209  EXPORT_SYMBOL(__page_table_check_pmd_set);
df4e817b710809 Pasha Tatashin 2022-01-14  210  
df4e817b710809 Pasha Tatashin 2022-01-14  211  void __page_table_check_pud_set(struct mm_struct *mm, unsigned long addr,
df4e817b710809 Pasha Tatashin 2022-01-14  212  				pud_t *pudp, pud_t pud)
df4e817b710809 Pasha Tatashin 2022-01-14  213  {
df4e817b710809 Pasha Tatashin 2022-01-14  214  	if (&init_mm == mm)
df4e817b710809 Pasha Tatashin 2022-01-14  215  		return;
df4e817b710809 Pasha Tatashin 2022-01-14  216  
64d8b9e14512ce Pasha Tatashin 2022-02-03  217  	__page_table_check_pud_clear(mm, addr, *pudp);
df4e817b710809 Pasha Tatashin 2022-01-14  218  	if (pud_user_accessible_page(pud)) {
df4e817b710809 Pasha Tatashin 2022-01-14  219  		page_table_check_set(mm, addr, pud_pfn(pud),
92fb05242a1b1e Tong Tiangen   2022-05-12  220  				     PUD_SIZE >> PAGE_SHIFT,
df4e817b710809 Pasha Tatashin 2022-01-14 @221  				     pud_write(pud));
df4e817b710809 Pasha Tatashin 2022-01-14  222  	}
df4e817b710809 Pasha Tatashin 2022-01-14  223  }
df4e817b710809 Pasha Tatashin 2022-01-14  224  EXPORT_SYMBOL(__page_table_check_pud_set);
80110bbfbba6f0 Pasha Tatashin 2022-02-03  225  
80110bbfbba6f0 Pasha Tatashin 2022-02-03  226  void __page_table_check_pte_clear_range(struct mm_struct *mm,
80110bbfbba6f0 Pasha Tatashin 2022-02-03  227  					unsigned long addr,
80110bbfbba6f0 Pasha Tatashin 2022-02-03  228  					pmd_t pmd)
80110bbfbba6f0 Pasha Tatashin 2022-02-03  229  {
80110bbfbba6f0 Pasha Tatashin 2022-02-03  230  	if (&init_mm == mm)
80110bbfbba6f0 Pasha Tatashin 2022-02-03  231  		return;
80110bbfbba6f0 Pasha Tatashin 2022-02-03  232  
80110bbfbba6f0 Pasha Tatashin 2022-02-03 @233  	if (!pmd_bad(pmd) && !pmd_leaf(pmd)) {
80110bbfbba6f0 Pasha Tatashin 2022-02-03 @234  		pte_t *ptep = pte_offset_map(&pmd, addr);
80110bbfbba6f0 Pasha Tatashin 2022-02-03  235  		unsigned long i;
80110bbfbba6f0 Pasha Tatashin 2022-02-03  236  
80110bbfbba6f0 Pasha Tatashin 2022-02-03 @237  		pte_unmap(ptep);
80110bbfbba6f0 Pasha Tatashin 2022-02-03 @238  		for (i = 0; i < PTRS_PER_PTE; i++) {

:::::: The code at line 148 was first introduced by commit
:::::: df4e817b710809425d899340dbfa8504a3ca4ba5 mm: page table check

:::::: TO: Pasha Tatashin <pasha.tatashin@...een.com>
:::::: CC: Linus Torvalds <torvalds@...ux-foundation.org>

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ