[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <e6e5547e-d4d4-03a5-43cd-90922f9d1959@redhat.com>
Date: Sat, 25 Jun 2022 06:28:40 -0700
From: Tom Rix <trix@...hat.com>
To: Tianfei Zhang <tianfei.zhang@...el.com>, yilun.xu@...el.com,
lee.jones@...aro.org
Cc: hao.wu@...el.com, linux-kernel@...r.kernel.org,
linux-fpga@...r.kernel.org, russell.h.weight@...el.com,
matthew.gerlach@...ux.intel.com
Subject: Re: [PATCH v3 1/3] mfd: intel-m10-bmc: rename the local variables
On 6/24/22 2:22 AM, Tianfei Zhang wrote:
> It had better use ddata for local variables which
> directly interacts with dev_get_drvdata()/dev_set_drvdata().
This is a cleanup, not related to the patchset, it should be split from
the patchset.
Tom
>
> Signed-off-by: Tianfei Zhang <tianfei.zhang@...el.com>
> ---
> drivers/mfd/intel-m10-bmc.c | 10 +++++-----
> 1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/mfd/intel-m10-bmc.c b/drivers/mfd/intel-m10-bmc.c
> index 8db3bcf5fccc..7e521df29c72 100644
> --- a/drivers/mfd/intel-m10-bmc.c
> +++ b/drivers/mfd/intel-m10-bmc.c
> @@ -86,15 +86,15 @@ static DEVICE_ATTR_RO(bmcfw_version);
> static ssize_t mac_address_show(struct device *dev,
> struct device_attribute *attr, char *buf)
> {
> - struct intel_m10bmc *max10 = dev_get_drvdata(dev);
> + struct intel_m10bmc *ddata = dev_get_drvdata(dev);
> unsigned int macaddr_low, macaddr_high;
> int ret;
>
> - ret = m10bmc_sys_read(max10, M10BMC_MAC_LOW, &macaddr_low);
> + ret = m10bmc_sys_read(ddata, M10BMC_MAC_LOW, &macaddr_low);
> if (ret)
> return ret;
>
> - ret = m10bmc_sys_read(max10, M10BMC_MAC_HIGH, &macaddr_high);
> + ret = m10bmc_sys_read(ddata, M10BMC_MAC_HIGH, &macaddr_high);
> if (ret)
> return ret;
>
> @@ -111,11 +111,11 @@ static DEVICE_ATTR_RO(mac_address);
> static ssize_t mac_count_show(struct device *dev,
> struct device_attribute *attr, char *buf)
> {
> - struct intel_m10bmc *max10 = dev_get_drvdata(dev);
> + struct intel_m10bmc *ddata = dev_get_drvdata(dev);
> unsigned int macaddr_high;
> int ret;
>
> - ret = m10bmc_sys_read(max10, M10BMC_MAC_HIGH, &macaddr_high);
> + ret = m10bmc_sys_read(ddata, M10BMC_MAC_HIGH, &macaddr_high);
> if (ret)
> return ret;
>
Powered by blists - more mailing lists