linux-kernel - Re: [PATCH] media: docs: Modify the section of User xattr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <241393bf-1fd3-ab25-867b-7132d7590aa8@gmail.com>
Date:   Sat, 25 Jun 2022 08:15:43 +0700
From:   Bagas Sanjaya <bagasdotme@...il.com>
To:     Deming Wang <wangdeming@...pur.com>, miklos@...redi.hu,
        corbet@....net
Cc:     linux-unionfs@...r.kernel.org, linux-doc@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] media: docs: Modify the section of User xattr

On 6/24/22 08:46, Deming Wang wrote:
> Delete duplicate words of "the".
> 

I think "Modify something" isn't clear subject, because reviewers
don't know at glance the logical change this patch is doing other
than actually reading the diff below.

For the patch message, what about "Remove duplicate the"?

In this case of trivial patch, it's OK to have the patch message
same as the subject, if the message can't be described more
concise but clearer.

> @@ -607,7 +607,7 @@ can be removed.
>  User xattr
>  ----------
>  
> -The the "-o userxattr" mount option forces overlayfs to use the
> +The "-o userxattr" mount option forces overlayfs to use the
>  "user.overlay." xattr namespace instead of "trusted.overlay.".  This is
>  useful for unprivileged mounting of overlayfs.
>  

The diff looks OK.

Thanks.

-- 
An old man doll... just what I always wanted! - Clara