linux-kernel - Re: [PATCH v2] rpmsg: fix possible refcount leak in rpmsg_register_device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <0bbee169-6fdc-b50e-87f7-1551dac821e2@linaro.org>
Date:   Sat, 25 Jun 2022 21:40:36 +0200
From:   Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To:     Mathieu Poirier <mathieu.poirier@...aro.org>
Cc:     Hangyu Hua <hbh25y@...il.com>, bjorn.andersson@...aro.org,
        gregkh@...uxfoundation.org, linux-remoteproc@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] rpmsg: fix possible refcount leak in
 rpmsg_register_device_override()

On 24/06/2022 20:43, Mathieu Poirier wrote:
> On Fri, 24 Jun 2022 at 11:45, Krzysztof Kozlowski
> <krzysztof.kozlowski@...aro.org> wrote:
>>
>> On 24/06/2022 19:36, Mathieu Poirier wrote:
>>> On Fri, Jun 24, 2022 at 10:41:20AM +0800, Hangyu Hua wrote:
>>>> rpmsg_register_device_override need to call put_device to free vch when
>>>> driver_set_override fails.
>>>>
>>>> Fix this by adding a put_device() to the error path.
>>>>
>>>> Fixes: bb17d110cbf2 ("rpmsg: Fix calling device_lock() on non-initialized device")
>>>
>>> This is funny... Neither Bjorn nor I have reviewed this patch...
>>
>> It was a fix for commit in Greg's tree and Greg's pick it up after a
>> week or something. I am not sure if that's actually funny that Greg has
>> to pick it up without review :(
>>
> 
> The patch was sent out on April 19th and committed 3 days later on
> April 22nd.  Is 3 days the new patch review time standard?

Neither 19th, nor 22nd are correct. The patch which you set you never
reviewed, so commit bb17d110cbf2 was sent on 29th of April:
https://lore.kernel.org/all/20220429195946.1061725-1-krzysztof.kozlowski@linaro.org/

And committed on 6 of May, which gives some time for review. Where did
you see the other dates?


Best regards,
Krzysztof