linux-kernel - Re: [PATCH v2 1/8] ksmbd: use vfs_llseek instead of dereferencing NULL

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YreI9h957ZWv99OR@zx2c4.com>
Date:   Sun, 26 Jun 2022 00:15:18 +0200
From:   "Jason A. Donenfeld" <Jason@...c4.com>
To:     Steve French <stfrench@...rosoft.com>
Cc:     Al Viro <viro@...iv.linux.org.uk>, linux-kernel@...r.kernel.org,
        linux-fsdevel@...r.kernel.org
Subject: Re: [PATCH v2 1/8] ksmbd: use vfs_llseek instead of dereferencing
 NULL

Hi Steve,

On Sat, Jun 25, 2022 at 01:01:08PM +0200, Jason A. Donenfeld wrote:
> By not checking whether llseek is NULL, this might jump to NULL. Also,
> it doesn't check FMODE_LSEEK. Fix this by using vfs_llseek(), which
> always does the right thing.
> 
> Fixes: f44158485826 ("cifsd: add file operations")
> Cc: stable@...r.kernel.org
> Cc: linux-cifs@...r.kernel.org
> Cc: Steve French <stfrench@...rosoft.com>
> Cc: Ronnie Sahlberg <lsahlber@...hat.com>
> Cc: Hyunchul Lee <hyc.lee@...il.com>
> Cc: Sergey Senozhatsky <sergey.senozhatsky@...il.com>
> Reviewed-by: Namjae Jeon <linkinjeon@...nel.org>
> Acked-by: Al Viro <viro@...iv.linux.org.uk>
> Signed-off-by: Jason A. Donenfeld <Jason@...c4.com>

This commit has been reviewed by Namjae and acked by Al. The rest of the
commits in this series are likely -next material for Al to take in his
vfs tree, but this first one here is something you might consider taking
as a somewhat important bug fix for 5.19. I marked it for stable@ and
such as well. Your call -- you can punt it to Al's -next branch with the
rest of the series if you want -- but I think this patch is a bit unlike
the others. This occurred to me when I saw you sent some cifs fixes in
earlier this evening.

Jason