linux-kernel - Re: [PATCH] dt-bindings: firmware: qcom-scm: convert to dtschema

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20220625015714.GA6675@quicinc.com>
Date:   Fri, 24 Jun 2022 18:57:14 -0700
From:   Guru Das Srinagesh <quic_gurus@...cinc.com>
To:     Robert Marko <robimarko@...il.com>
CC:     Andy Gross <agross@...nel.org>,
        Bjorn Andersson <bjorn.andersson@...aro.org>,
        Rob Herring <robh+dt@...nel.org>,
        <krzysztof.kozlowski+dt@...aro.org>,
        linux-arm-msm <linux-arm-msm@...r.kernel.org>,
        Devicetree List <devicetree@...r.kernel.org>,
        open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] dt-bindings: firmware: qcom-scm: convert to dtschema

On Jun 24 2022 10:50, Robert Marko wrote:
> On Fri, 24 Jun 2022 at 03:01, Guru Das Srinagesh <quic_gurus@...cinc.com> wrote:
> >
> > On Thu, Jun 23, 2022 at 08:25:42PM +0200, Robert Marko wrote:
> >
> > > +
> > > +description: |
> > ...
> > > +
> > > +  '#reset-cells':
> > > +    const: 1
> >
> > This isn't part of the original file - could you please explain why this is
> > being added?
> 
> Yes, its not part of the original file, however I noticed that a lot of SCM
> nodes were adding #reset-cells, and upon looking at the SCM code its
> clear that it is being registered as a reset controller so #reset-cells are
> appropriate.
> 
> However, since its not really being used via phandles #reset-cells did
> not really matter, hence why I did not add them to be required,
> this is something that DT guys can probably clarify.

Makes sense, ACK.

Thank you.

Guru Das.