linux-kernel - Re: [PATCH v2 2/2] pinctrl: Add Cypress cy8c95x0 support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CACRpkdakd1T9FFfjbSpLnCmOQM-HVLy+UTJBKkpphyDVmZt6yg@mail.gmail.com>
Date:   Sun, 26 Jun 2022 01:08:53 +0200
From:   Linus Walleij <linus.walleij@...aro.org>
To:     Patrick Rudolph <patrick.rudolph@...ements.com>
Cc:     Naresh Solanki <naresh.solanki@...ements.com>,
        linux-kernel@...r.kernel.org, linux-gpio@...r.kernel.org
Subject: Re: [PATCH v2 2/2] pinctrl: Add Cypress cy8c95x0 support

On Wed, Jun 15, 2022 at 12:50 PM Patrick Rudolph
<patrick.rudolph@...ements.com> wrote:

> Add support for cypress I2C GPIO expanders cy8c9520, cy8c9540 and
> cy8c9560. The GPIO expanders feature a PWM mode, thus add it as
> pinctrl driver.
>
> The chip features multiple drive modes for each pin when configured
> as output and multiple bias settings when configured as input.
>
> Tested all three components and verified that all functionality
> is fully working.
>
> Datasheet: https://www.cypress.com/file/37971/download
> Signed-off-by: Patrick Rudolph <patrick.rudolph@...ements.com>
> Signed-off-by: Naresh Solanki <naresh.solanki@...ements.com>

Looks good to me, I see there are still some comments on the bindings,
once that is fixed this is good to go.

Yours,
Linus Walleij