lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date:   Sat, 25 Jun 2022 10:54:45 +0800
From:   kernel test robot <lkp@...el.com>
To:     Marcin Wojtas <mw@...ihalf.com>, linux-kernel@...r.kernel.org,
        linux-acpi@...r.kernel.org, netdev@...r.kernel.org
Cc:     kbuild-all@...ts.01.org, rafael@...nel.org,
        andriy.shevchenko@...ux.intel.com, lenb@...nel.org, andrew@...n.ch,
        vivien.didelot@...il.com, f.fainelli@...il.com, olteanv@...il.com,
        davem@...emloft.net, edumazet@...gle.com, kuba@...nel.org,
        pabeni@...hat.com, linux@...linux.org.uk, hkallweit1@...il.com,
        gjb@...ihalf.com, mw@...ihalf.com, jaz@...ihalf.com,
        tn@...ihalf.com, Samer.El-Haj-Mahmoud@....com,
        upstream@...ihalf.com
Subject: Re: [net-next: PATCH 12/12] net: dsa: mv88e6xxx: add ACPI support

Hi Marcin,

I love your patch! Perhaps something to improve:

[auto build test WARNING on rafael-pm/linux-next]
[also build test WARNING on robh/for-next linus/master v5.19-rc3 next-20220623]
[cannot apply to horms-ipvs/master]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/intel-lab-lkp/linux/commits/Marcin-Wojtas/ACPI-support-for-DSA/20220620-231646
base:   https://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm.git linux-next
config: ia64-allyesconfig
compiler: ia64-linux-gcc (GCC) 11.3.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/intel-lab-lkp/linux/commit/b3d15b4cbd3c4de7799791e739317bdf6304c6de
        git remote add linux-review https://github.com/intel-lab-lkp/linux
        git fetch --no-tags linux-review Marcin-Wojtas/ACPI-support-for-DSA/20220620-231646
        git checkout b3d15b4cbd3c4de7799791e739317bdf6304c6de
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.3.0 make.cross W=1 O=build_dir ARCH=ia64 SHELL=/bin/bash drivers/net/

If you fix the issue, kindly add following tag where applicable
Reported-by: kernel test robot <lkp@...el.com>

All warnings (new ones prefixed by >>):

   drivers/net/dsa/mv88e6xxx/chip.c: In function 'mv88e6xxx_mdios_register':
>> drivers/net/dsa/mv88e6xxx/chip.c:3966:17: warning: 'strncpy' output truncated before terminating nul copying 4 bytes from a string of the same length [-Wstringop-truncation]
    3966 |                 strncpy(mdio_node_name, "MDIO", ACPI_NAMESEG_SIZE);
         |                 ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   {standard input}: Assembler messages:
   {standard input}:1908: Error: Register number out of range 0..1
   {standard input}:1908: Warning: Use of 'mov' violates WAW dependency 'GR%, % in 1 - 127' (impliedf), specific resource number is 39
   {standard input}:1908: Warning: Only the first path encountering the conflict is reported
   {standard input}:1906: Warning: This is the location of the conflicting usage
   {standard input}:1910: Error: Register number out of range 0..1
   {standard input}:1910: Warning: Use of 'mov' violates WAW dependency 'GR%, % in 1 - 127' (impliedf), specific resource number is 39
   {standard input}:1910: Warning: Only the first path encountering the conflict is reported
   {standard input}:1906: Warning: This is the location of the conflicting usage
   {standard input}:1910: Warning: Use of 'mov' violates WAW dependency 'GR%, % in 1 - 127' (impliedf), specific resource number is 39
   {standard input}:1910: Warning: Only the first path encountering the conflict is reported
   {standard input}:1908: Warning: This is the location of the conflicting usage
   {standard input}:1911: Error: Register number out of range 0..1
   {standard input}:1911: Warning: Use of 'mov' violates WAW dependency 'GR%, % in 1 - 127' (impliedf), specific resource number is 39
   {standard input}:1911: Warning: Only the first path encountering the conflict is reported
   {standard input}:1906: Warning: This is the location of the conflicting usage
   {standard input}:1911: Warning: Use of 'mov' violates WAW dependency 'GR%, % in 1 - 127' (impliedf), specific resource number is 39
   {standard input}:1911: Warning: Only the first path encountering the conflict is reported
   {standard input}:1908: Warning: This is the location of the conflicting usage
   {standard input}:1911: Warning: Use of 'mov' violates WAW dependency 'GR%, % in 1 - 127' (impliedf), specific resource number is 39
   {standard input}:1911: Warning: Only the first path encountering the conflict is reported
   {standard input}:1910: Warning: This is the location of the conflicting usage
   {standard input}:1912: Error: Register number out of range 0..1
   {standard input}:1912: Warning: Use of 'mov' violates WAW dependency 'GR%, % in 1 - 127' (impliedf), specific resource number is 39
   {standard input}:1912: Warning: Only the first path encountering the conflict is reported
   {standard input}:1906: Warning: This is the location of the conflicting usage
   {standard input}:1912: Warning: Use of 'mov' violates WAW dependency 'GR%, % in 1 - 127' (impliedf), specific resource number is 39
   {standard input}:1912: Warning: Only the first path encountering the conflict is reported
   {standard input}:1908: Warning: This is the location of the conflicting usage
   {standard input}:1912: Warning: Use of 'mov' violates WAW dependency 'GR%, % in 1 - 127' (impliedf), specific resource number is 39
   {standard input}:1912: Warning: Only the first path encountering the conflict is reported
   {standard input}:1910: Warning: This is the location of the conflicting usage
   {standard input}:1912: Warning: Use of 'mov' violates WAW dependency 'GR%, % in 1 - 127' (impliedf), specific resource number is 39
   {standard input}:1912: Warning: Only the first path encountering the conflict is reported
   {standard input}:1911: Warning: This is the location of the conflicting usage
   {standard input}:1915: Error: Register number out of range 0..1
   {standard input}:1916: Error: Register number out of range 0..1
   {standard input}:1916: Warning: Use of 'mov' violates WAW dependency 'GR%, % in 1 - 127' (impliedf), specific resource number is 39
   {standard input}:1916: Warning: Only the first path encountering the conflict is reported
   {standard input}:1915: Warning: This is the location of the conflicting usage
   {standard input}:4791: Error: Register number out of range 0..3
   {standard input}:4792: Error: Register number out of range 0..3
   {standard input}:4792: Warning: Use of 'mov' violates WAW dependency 'GR%, % in 1 - 127' (impliedf), specific resource number is 52
   {standard input}:4792: Warning: Only the first path encountering the conflict is reported
   {standard input}:4791: Warning: This is the location of the conflicting usage
   {standard input}:4793: Error: Register number out of range 0..3
   {standard input}:4793: Warning: Use of 'mov' violates WAW dependency 'GR%, % in 1 - 127' (impliedf), specific resource number is 52
   {standard input}:4793: Warning: Only the first path encountering the conflict is reported
   {standard input}:4791: Warning: This is the location of the conflicting usage
   {standard input}:4793: Warning: Use of 'mov' violates WAW dependency 'GR%, % in 1 - 127' (impliedf), specific resource number is 52
   {standard input}:4793: Warning: Only the first path encountering the conflict is reported
   {standard input}:4792: Warning: This is the location of the conflicting usage
   {standard input}:4797: Error: Register number out of range 0..3
   {standard input}:5097: Error: Register number out of range 0..2
   {standard input}:5097: Warning: Use of 'mov' violates WAW dependency 'GR%, % in 1 - 127' (impliedf), specific resource number is 40
   {standard input}:5093: Warning: This is the location of the conflicting usage
   {standard input}:5098: Error: Register number out of range 0..2
   {standard input}:5098: Warning: Use of 'mov' violates WAW dependency 'GR%, % in 1 - 127' (impliedf), specific resource number is 40
   {standard input}:5093: Warning: This is the location of the conflicting usage
   {standard input}:5098: Warning: Use of 'mov' violates WAW dependency 'GR%, % in 1 - 127' (impliedf), specific resource number is 40
   {standard input}:5097: Warning: This is the location of the conflicting usage
   {standard input}:5099: Error: Register number out of range 0..2
   {standard input}:5099: Warning: Use of 'mov' violates WAW dependency 'GR%, % in 1 - 127' (impliedf), specific resource number is 40
   {standard input}:5093: Warning: This is the location of the conflicting usage
   {standard input}:5099: Warning: Use of 'mov' violates WAW dependency 'GR%, % in 1 - 127' (impliedf), specific resource number is 40
   {standard input}:5097: Warning: This is the location of the conflicting usage
   {standard input}:5099: Warning: Use of 'mov' violates WAW dependency 'GR%, % in 1 - 127' (impliedf), specific resource number is 40
   {standard input}:5098: Warning: This is the location of the conflicting usage
   {standard input}:5102: Error: Register number out of range 0..2
   {standard input}:5103: Error: Register number out of range 0..2
   {standard input}:5103: Warning: Use of 'mov' violates WAW dependency 'GR%, % in 1 - 127' (impliedf), specific resource number is 40
   {standard input}:5102: Warning: This is the location of the conflicting usage
   {standard input}:10057: Error: Register number out of range 0..2
   {standard input}:10059: Error: Register number out of range 0..2
   {standard input}:10059: Warning: Use of 'mov' violates WAW dependency 'GR%, % in 1 - 127' (impliedf), specific resource number is 40
   {standard input}:10059: Warning: Only the first path encountering the conflict is reported
   {standard input}:10057: Warning: This is the location of the conflicting usage
   {standard input}:10060: Error: Register number out of range 0..2
   {standard input}:10060: Warning: Use of 'mov' violates WAW dependency 'GR%, % in 1 - 127' (impliedf), specific resource number is 40
   {standard input}:10060: Warning: Only the first path encountering the conflict is reported
   {standard input}:10057: Warning: This is the location of the conflicting usage
   {standard input}:10060: Warning: Use of 'mov' violates WAW dependency 'GR%, % in 1 - 127' (impliedf), specific resource number is 40
   {standard input}:10060: Warning: Only the first path encountering the conflict is reported
   {standard input}:10059: Warning: This is the location of the conflicting usage
   {standard input}:10061: Error: Register number out of range 0..2
   {standard input}:10061: Warning: Use of 'mov' violates WAW dependency 'GR%, % in 1 - 127' (impliedf), specific resource number is 40
   {standard input}:10061: Warning: Only the first path encountering the conflict is reported
   {standard input}:10057: Warning: This is the location of the conflicting usage
   {standard input}:10061: Warning: Use of 'mov' violates WAW dependency 'GR%, % in 1 - 127' (impliedf), specific resource number is 40
   {standard input}:10061: Warning: Only the first path encountering the conflict is reported
   {standard input}:10059: Warning: This is the location of the conflicting usage
   {standard input}:10061: Warning: Use of 'mov' violates WAW dependency 'GR%, % in 1 - 127' (impliedf), specific resource number is 40
   {standard input}:10061: Warning: Only the first path encountering the conflict is reported
   {standard input}:10060: Warning: This is the location of the conflicting usage
   {standard input}:10065: Error: Register number out of range 0..2
   {standard input}:10390: Error: Register number out of range 0..3
   {standard input}:10391: Error: Register number out of range 0..3
   {standard input}:10391: Warning: Use of 'mov' violates WAW dependency 'GR%, % in 1 - 127' (impliedf), specific resource number is 43


vim +/strncpy +3966 drivers/net/dsa/mv88e6xxx/chip.c

  3956	
  3957	static int mv88e6xxx_mdios_register(struct mv88e6xxx_chip *chip,
  3958					    struct fwnode_handle *fwnode)
  3959	{
  3960		char mdio_node_name[] = "mdio";
  3961		struct fwnode_handle *child;
  3962		int err;
  3963	
  3964		/* Update subnode name if operating in the ACPI world. */
  3965		if (is_acpi_node(fwnode))
> 3966			strncpy(mdio_node_name, "MDIO", ACPI_NAMESEG_SIZE);
  3967	
  3968		/* Always register one mdio bus for the internal/default mdio
  3969		 * bus. This maybe represented in the device tree, but is
  3970		 * optional.
  3971		 */
  3972		child = fwnode_get_named_child_node(fwnode, mdio_node_name);
  3973		err = mv88e6xxx_mdio_register(chip, child, false);
  3974		fwnode_handle_put(child);
  3975		if (err)
  3976			return err;
  3977	
  3978		/* Walk the device tree, and see if there are any other nodes
  3979		 * which say they are compatible with the external mdio
  3980		 * bus.
  3981		 */
  3982		fwnode_for_each_available_child_node(fwnode, child) {
  3983			if (fwnode_property_match_string(child, "compatible",
  3984							 "marvell,mv88e6xxx-mdio-external") == 0) {
  3985				err = mv88e6xxx_mdio_register(chip, child, true);
  3986				if (err) {
  3987					mv88e6xxx_mdios_unregister(chip);
  3988					fwnode_handle_put(child);
  3989					return err;
  3990				}
  3991			}
  3992		}
  3993	
  3994		return 0;
  3995	}
  3996	

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp

View attachment "config" of type "text/plain" (314503 bytes)

Powered by blists - more mailing lists