[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <YrgSj8w+Q3HmSEwv@infradead.org>
Date: Sun, 26 Jun 2022 01:02:23 -0700
From: Christoph Hellwig <hch@...radead.org>
To: "Darrick J. Wong" <djwong@...nel.org>
Cc: Eric Biggers <ebiggers@...nel.org>, linux-fsdevel@...r.kernel.org,
linux-ext4@...r.kernel.org, linux-f2fs-devel@...ts.sourceforge.net,
linux-xfs@...r.kernel.org, linux-api@...r.kernel.org,
linux-fscrypt@...r.kernel.org, linux-block@...r.kernel.org,
linux-kernel@...r.kernel.org, Keith Busch <kbusch@...nel.org>
Subject: Re: [PATCH v3 1/8] statx: add direct I/O alignment information
On Thu, Jun 23, 2022 at 08:58:12AM -0700, Darrick J. Wong wrote:
> Hmm. Does the XFS port of XFS_IOC_DIOINFO to STATX_DIOALIGN look like
> this?
>
> struct xfs_buftarg *target = xfs_inode_buftarg(ip);
>
> kstat.dio_mem_align = target->bt_logical_sectorsize;
> kstat.dio_offset_align = target->bt_logical_sectorsize;
> kstat.result_mask |= STATX_DIOALIGN;
Yes, I think so. And it would be very good to include the XFS conversion
with this series as the only file systems that already supports
reporting alignment constraints.
I also suspect that lifting XFS_IOC_DIOINFO to common code by calling
->getattr would be useful because now all existing software using that
will also do the right thing on ext4 and f2fs now.
Powered by blists - more mailing lists