linux-kernel - Re: [PATCH 2/3] iio: pressure: bmp280: Add support for BMP380 sensor family

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Sun, 26 Jun 2022 09:24:23 +0800
From:   kernel test robot <lkp@...el.com>
To:     Angel Iglesias <ang.iglesiasg@...il.com>
Cc:     kbuild-all@...ts.01.org, Angel Iglesias <ang.iglesiasg@...il.com>,
        Jonathan Cameron <jic23@...nel.org>,
        Lars-Peter Clausen <lars@...afoo.de>,
        "Rafael J. Wysocki" <rafael.j.wysocki@...el.com>,
        Ulf Hansson <ulf.hansson@...aro.org>,
        Paul Cercueil <paul@...pouillou.net>,
        linux-iio@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/3] iio: pressure: bmp280: Add support for BMP380 sensor
 family

Hi Angel,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on jic23-iio/togreg]
[also build test WARNING on robh/for-next linus/master v5.19-rc3 next-20220624]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/intel-lab-lkp/linux/commits/Angel-Iglesias/dt-bindings-iio-pressure-bmp085-Add-BMP380-compatible-string/20220625-231424
base:   https://git.kernel.org/pub/scm/linux/kernel/git/jic23/iio.git togreg
config: i386-randconfig-s001
compiler: gcc-11 (Debian 11.3.0-3) 11.3.0
reproduce:
        # apt-get install sparse
        # sparse version: v0.6.4-31-g4880bd19-dirty
        # https://github.com/intel-lab-lkp/linux/commit/56e3f8aecddacdbe204fbe5e28032ef2befae647
        git remote add linux-review https://github.com/intel-lab-lkp/linux
        git fetch --no-tags linux-review Angel-Iglesias/dt-bindings-iio-pressure-bmp085-Add-BMP380-compatible-string/20220625-231424
        git checkout 56e3f8aecddacdbe204fbe5e28032ef2befae647
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        make W=1 C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' O=build_dir ARCH=i386 SHELL=/bin/bash drivers/iio/pressure/

If you fix the issue, kindly add following tag where applicable
Reported-by: kernel test robot <lkp@...el.com>


sparse warnings: (new ones prefixed by >>)
   drivers/iio/pressure/bmp280-core.c:928:21: sparse: sparse: cast to restricted __le16
>> drivers/iio/pressure/bmp280-core.c:928:21: sparse: sparse: restricted __le16 degrades to integer
   drivers/iio/pressure/bmp280-core.c:928:21: sparse: sparse: cast to restricted __le16
>> drivers/iio/pressure/bmp280-core.c:928:21: sparse: sparse: restricted __le16 degrades to integer
   drivers/iio/pressure/bmp280-core.c:928:21: sparse: sparse: cast to restricted __le16
   drivers/iio/pressure/bmp280-core.c:929:21: sparse: sparse: cast to restricted __le16
   drivers/iio/pressure/bmp280-core.c:929:21: sparse: sparse: restricted __le16 degrades to integer
   drivers/iio/pressure/bmp280-core.c:929:21: sparse: sparse: cast to restricted __le16
   drivers/iio/pressure/bmp280-core.c:929:21: sparse: sparse: restricted __le16 degrades to integer
   drivers/iio/pressure/bmp280-core.c:929:21: sparse: sparse: cast to restricted __le16
   drivers/iio/pressure/bmp280-core.c:931:21: sparse: sparse: cast to restricted __le16
   drivers/iio/pressure/bmp280-core.c:931:21: sparse: sparse: restricted __le16 degrades to integer
   drivers/iio/pressure/bmp280-core.c:931:21: sparse: sparse: cast to restricted __le16
   drivers/iio/pressure/bmp280-core.c:931:21: sparse: sparse: restricted __le16 degrades to integer
   drivers/iio/pressure/bmp280-core.c:931:21: sparse: sparse: cast to restricted __le16
   drivers/iio/pressure/bmp280-core.c:932:21: sparse: sparse: cast to restricted __le16
   drivers/iio/pressure/bmp280-core.c:932:21: sparse: sparse: restricted __le16 degrades to integer
   drivers/iio/pressure/bmp280-core.c:932:21: sparse: sparse: cast to restricted __le16
   drivers/iio/pressure/bmp280-core.c:932:21: sparse: sparse: restricted __le16 degrades to integer
   drivers/iio/pressure/bmp280-core.c:932:21: sparse: sparse: cast to restricted __le16
   drivers/iio/pressure/bmp280-core.c:935:21: sparse: sparse: cast to restricted __le16
   drivers/iio/pressure/bmp280-core.c:935:21: sparse: sparse: restricted __le16 degrades to integer
   drivers/iio/pressure/bmp280-core.c:935:21: sparse: sparse: cast to restricted __le16
   drivers/iio/pressure/bmp280-core.c:935:21: sparse: sparse: restricted __le16 degrades to integer
   drivers/iio/pressure/bmp280-core.c:935:21: sparse: sparse: cast to restricted __le16
   drivers/iio/pressure/bmp280-core.c:936:21: sparse: sparse: cast to restricted __le16
   drivers/iio/pressure/bmp280-core.c:936:21: sparse: sparse: restricted __le16 degrades to integer
   drivers/iio/pressure/bmp280-core.c:936:21: sparse: sparse: cast to restricted __le16
   drivers/iio/pressure/bmp280-core.c:936:21: sparse: sparse: restricted __le16 degrades to integer
   drivers/iio/pressure/bmp280-core.c:936:21: sparse: sparse: cast to restricted __le16
   drivers/iio/pressure/bmp280-core.c:939:21: sparse: sparse: cast to restricted __le16
   drivers/iio/pressure/bmp280-core.c:939:21: sparse: sparse: restricted __le16 degrades to integer
   drivers/iio/pressure/bmp280-core.c:939:21: sparse: sparse: cast to restricted __le16
   drivers/iio/pressure/bmp280-core.c:939:21: sparse: sparse: restricted __le16 degrades to integer
   drivers/iio/pressure/bmp280-core.c:939:21: sparse: sparse: cast to restricted __le16

vim +928 drivers/iio/pressure/bmp280-core.c

   908	
   909	static int bmp380_read_calib(struct bmp280_data *data,
   910				     struct bmp380_calib *calib, unsigned int chip)
   911	{
   912		int ret;
   913		u8 buf[BMP380_CALIB_REG_COUNT];
   914	
   915		/* Read temperature calibration values. */
   916		ret = regmap_bulk_read(data->regmap, BMP380_REG_CALIB_TEMP_START, buf,
   917				       BMP380_CALIB_REG_COUNT);
   918		if (ret < 0) {
   919			dev_err(data->dev,
   920				"failed to read temperature calibration parameters\n");
   921			return ret;
   922		}
   923	
   924		/* Toss the temperature calibration data into the entropy pool */
   925		add_device_randomness(buf, sizeof(buf));
   926	
   927		/* Parse calibration data */
 > 928		calib->T1 = le16_from_bytes(buf[BMP380_T1], buf[BMP380_T1 + 1]);
   929		calib->T2 = le16_from_bytes(buf[BMP380_T2], buf[BMP380_T2 + 1]);
   930		calib->T3 = buf[BMP380_T3];
   931		calib->P1 = le16_from_bytes(buf[BMP380_P1], buf[BMP380_P1 + 1]);
   932		calib->P2 = le16_from_bytes(buf[BMP380_P2], buf[BMP380_P2 + 1]);
   933		calib->P3 = buf[BMP380_P3];
   934		calib->P4 = buf[BMP380_P4];
   935		calib->P5 = le16_from_bytes(buf[BMP380_P5], buf[BMP380_P5 + 1]);
   936		calib->P6 = le16_from_bytes(buf[BMP380_P6], buf[BMP380_P6 + 1]);
   937		calib->P7 = buf[BMP380_P7];
   938		calib->P8 = buf[BMP380_P8];
   939		calib->P9 = le16_from_bytes(buf[BMP380_P9], buf[BMP380_P9 + 1]);
   940		calib->P10 = buf[BMP380_P10];
   941		calib->P11 = buf[BMP380_P11];
   942	
   943		return 0;
   944	}
   945	

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp