[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <6b950660-6a78-f329-39b4-11d585e4959c@gmx.de>
Date: Sun, 26 Jun 2022 14:18:17 +0200
From: Lino Sanfilippo <LinoSanfilippo@....de>
To: Jarkko Sakkinen <jarkko@...nel.org>
Cc: peterhuewe@....de, jgg@...pe.ca, stefanb@...ux.vnet.ibm.com,
linux@...ewoehner.de, linux-integrity@...r.kernel.org,
linux-kernel@...r.kernel.org, l.sanfilippo@...bus.com,
lukas@...ner.de, p.rosenberger@...bus.com
Subject: Re: [PATCH v6 5/9] tpm, tpm_tis: Only handle supported interrupts
On 26.06.22 at 08:40, Jarkko Sakkinen wrote:
>
> I would instead mask out bits and write a helper function
> taking care of this:
>
> static u8 tpm_tis_filter_sts_mask(u8 int_mask, u8 sts_mask)
> {
> struct tpm_tis_data *priv = dev_get_drvdata(&chip->dev);
>
> if (!(int_mask & TPM_INTF_STS_VALID_INT))
> sts_mask &= ~TPM_STS_VALID;
>
> if (!(int_mask & TPM_INTF_DATA_AVAIL_INT))
> sts_mask &= ~TPM_STS_DATA_AVAIL;
>
> if (!(int_mask & TPM_INTF_CMD_READY_INT))
> sts_mask &= ~TPM_STS_COMMAND_READY;
>
> return sts_mask;
> }
>
> Less operations and imho somewhat cleaner structure.
>
> Add suggested-by if you want.
I thought of a helper like this before but then decided to
not introduce another function to keep the code changes minimal. But yes,
it is indeed cleaner. I will do the change and resubmit the series.
Thanks for the review!
Regards,
Lino
Powered by blists - more mailing lists