linux-kernel - Re: [PATCH 01/36] serial: Add uart_rs485

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <918ab6d2-c0f8-fd74-8e80-36d86ba82255@gmx.de>
Date:   Sun, 26 Jun 2022 14:36:51 +0200
From:   Lino Sanfilippo <LinoSanfilippo@....de>
To:     Lukas Wunner <lukas@...ner.de>,
        Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>
Cc:     linux-serial@...r.kernel.org, Greg KH <gregkh@...uxfoundation.org>,
        Jiri Slaby <jirislaby@...nel.org>,
        Shawn Guo <shawnguo@...nel.org>,
        Sascha Hauer <s.hauer@...gutronix.de>,
        Pengutronix Kernel Team <kernel@...gutronix.de>,
        Fabio Estevam <festevam@...il.com>,
        NXP Linux Team <linux-imx@....com>,
        linux-kernel@...r.kernel.org,
        Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
Subject: Re: [PATCH 01/36] serial: Add uart_rs485_config()

On 25.06.22 at 22:19, Lukas Wunner wrote:

>
> Why doesn't this helper acquire the port spinlock, unlike
> uart_set_rs485_config()?  Is this safe?  Do all callers hold the lock?
> Do we need an assertion to verify the lock is held?
>

AFAIU the callers are using this only during initialization, so there is nothing else
at this time that accesses the serial_rs485 struct and thus no need for locking.

Regards,
Lino