linux-kernel - Re: [GIT PULL] Kbuild fixes for v5.19-rc4

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sun, 26 Jun 2022 11:19:40 -0700
From:   Linus Torvalds <torvalds@...ux-foundation.org>
To:     Masahiro Yamada <masahiroy@...nel.org>,
        "Paul E. McKenney" <paulmck@...nel.org>
Cc:     Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Linux Kbuild mailing list <linux-kbuild@...r.kernel.org>
Subject: Re: [GIT PULL] Kbuild fixes for v5.19-rc4

On Sat, Jun 25, 2022 at 3:16 PM Masahiro Yamada <masahiroy@...nel.org> wrote:
>
> Please pull a couple of Kbuild fixes.

Masahiro, I already complained about this once:

    Section mismatch in reference from the variable .. declared __init

and now you re-introduced this sneakily by just putting it in another place.

I told you last time that you need to *FIX* these things before adding
the warning, instead of adding a warning and then waiting for others
to fix them.

Yes, it's fixing an earlier mistake, but that earlier mistake is over
a decade old by now.

Now, the only warning that seems to show up for me is about
tick_nohz_full_setup. Which is only called from housekeeping_setup()
in kernel/sched/isolation.c if I grepped correctly.

And that seems only ever built-in as far as I can tell, so the whole
export seems pointless, and the fix is presumably to remove the
export_SYMBOL_GPL entirely.

So it seems fixable.

But I'm upset about this sneaking in when we _talked_ about this issue earlier.

Paul - that export was added by commit ae9e557b5be2 ("time: Export
tick start/stop functions for rcutorture"), and it seems to have been
bogus even at that time.

              Linus