linux-kernel - Re: [PATCH] platform: x86: Remove duplicated include in barco-p50-gpio.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <8735fr1bqh.fsf@dell.be.48ers.dk>
Date:   Sun, 26 Jun 2022 21:11:18 +0200
From:   Peter Korsgaard <peter@...sgaard.com>
To:     Saurav Girepunje <saurav.girepunje@...il.com>
Cc:     santoshkumar.yadav@...co.com, peter.korsgaard@...co.com,
        hdegoede@...hat.com, markgross@...nel.org,
        platform-driver-x86@...r.kernel.org, linux-kernel@...r.kernel.org,
        saurav.girepunje@...mail.com
Subject: Re: [PATCH] platform: x86: Remove duplicated include in
 barco-p50-gpio.c

>>>>> "Saurav" == Saurav Girepunje <saurav.girepunje@...il.com> writes:

 > Remove the duplicate include of linux/io.h in barco-p50-gpio.c
 > file.

 > Signed-off-by: Saurav Girepunje <saurav.girepunje@...il.com>

What tree is this against? The io.h include in the line just above
delay.h was already removed by:

commit 011881b80ebe773914b59905bce0f5e0ef93e7ba
Author: Jiasheng Jiang <jiasheng@...as.ac.cn>
Date:   Thu May 26 17:03:45 2022 +0800

    platform/x86: barco-p50-gpio: Add check for platform_driver_register

    As platform_driver_register() could fail, it should be better
    to deal with the return value in order to maintain the code
    consisitency.

    Fixes: 86af1d02d458 ("platform/x86: Support for EC-connected GPIOs for identify LED/button on Barco P50 board")
    Signed-off-by: Jiasheng Jiang <jiasheng@...as.ac.cn>
    Acked-by: Peter Korsgaard <peter.korsgaard@...co.com>
    Link: https://lore.kernel.org/r/20220526090345.1444172-1-jiasheng@iscas.ac.cn
    Signed-off-by: Hans de Goede <hdegoede@...hat.com>

> ---
 >  drivers/platform/x86/barco-p50-gpio.c | 1 -
 >  1 file changed, 1 deletion(-)

 > diff --git a/drivers/platform/x86/barco-p50-gpio.c b/drivers/platform/x86/barco-p50-gpio.c
 > index f5c72e33f9ae..bb8ed8e95225 100644
 > --- a/drivers/platform/x86/barco-p50-gpio.c
 > +++ b/drivers/platform/x86/barco-p50-gpio.c
 > @@ -14,7 +14,6 @@
 >  #include <linux/delay.h>
 >  #include <linux/dmi.h>
 >  #include <linux/err.h>
 > -#include <linux/io.h>
 >  #include <linux/kernel.h>
 >  #include <linux/leds.h>
 >  #include <linux/module.h>
 > --
 > 2.33.0


-- 
Bye, Peter Korsgaard