lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date:   Mon, 27 Jun 2022 02:32:24 +0300
From:   Laurent Pinchart <laurent.pinchart@...asonboard.com>
To:     Jiang Jian <jiangjian@...rlc.com>
Cc:     mchehab@...nel.org, hyun.kwon@...inx.com, michal.simek@...inx.com,
        linux-media@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] media: xilinx: drop unexpected word 'with' in comments

Hi Jiang,

Thank you for the patch.

On Thu, Jun 23, 2022 at 08:29:48PM +0800, Jiang Jian wrote:
> there is an unexpected word 'with' in the comments that need to be dropped
> 
> file - drivers/media/platform/xilinx/xilinx-vip.h
> line -31
> 
>  * Pad IDs. IP cores with with multiple inputs or outputs should define
> 
> changed to:
> 
>  * Pad IDs. IP cores with multiple inputs or outputs should define

The first line of the commit message is enough, the rest duplicates the
content of the patch. No need to resubmit, I'll fix this when applying.

Reviewed-by: Laurent Pinchart <laurent.pinchart@...asonboard.com>

> Signed-off-by: Jiang Jian <jiangjian@...rlc.com>
> ---
>  drivers/media/platform/xilinx/xilinx-vip.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/media/platform/xilinx/xilinx-vip.h b/drivers/media/platform/xilinx/xilinx-vip.h
> index d0b0e0600952..1c8dd59067fe 100644
> --- a/drivers/media/platform/xilinx/xilinx-vip.h
> +++ b/drivers/media/platform/xilinx/xilinx-vip.h
> @@ -28,7 +28,7 @@ struct clk;
>  #define XVIP_MAX_HEIGHT			7680
>  
>  /*
> - * Pad IDs. IP cores with with multiple inputs or outputs should define
> + * Pad IDs. IP cores with multiple inputs or outputs should define
>   * their own values.
>   */
>  #define XVIP_PAD_SINK			0

-- 
Regards,

Laurent Pinchart

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ