linux-kernel - Re: [PATCH v2 4/5] pinctrl: mediatek: dropping original advanced drive configuration function

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sun, 26 Jun 2022 12:44:31 +0800
From:   Guodong Liu <guodong.liu@...iatek.com>
To:     "Nícolas F. R. A. Prado" <nfraprado@...labora.com>
CC:     Linus Walleij <linus.walleij@...aro.org>,
        Rob Herring <robh+dt@...nel.org>,
        Matthias Brugger <matthias.bgg@...il.com>,
        Sean Wang <sean.wang@...nel.org>,
        Sean Wang <sean.wang@...iatek.com>,
        Zhiyong Tao <zhiyong.tao@...iatek.com>,
        <linux-gpio@...r.kernel.org>, <devicetree@...r.kernel.org>,
        <linux-arm-kernel@...ts.infradead.org>,
        <linux-mediatek@...ts.infradead.org>,
        <linux-kernel@...r.kernel.org>,
        <Project_Global_Chrome_Upstream_Group@...iatek.com>
Subject: Re: [PATCH v2 4/5] pinctrl: mediatek: dropping original advanced
 drive configuration function

-----Original Message-----
From: Nícolas F. R. A. Prado <nfraprado@...labora.com>
To: Guodong Liu <guodong.liu@...iatek.com>
Cc: Linus Walleij <linus.walleij@...aro.org>, Rob Herring <
robh+dt@...nel.org>, Matthias Brugger <matthias.bgg@...il.com>, Sean
Wang <sean.wang@...nel.org>, Sean Wang <sean.wang@...iatek.com>,
Zhiyong Tao <zhiyong.tao@...iatek.com>, linux-gpio@...r.kernel.org, 
devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org, 
linux-mediatek@...ts.infradead.org, linux-kernel@...r.kernel.org, 
Project_Global_Chrome_Upstream_Group@...iatek.com
Subject: Re: [PATCH v2 4/5] pinctrl: mediatek: dropping original
advanced drive configuration function
Date: Fri, 24 Jun 2022 12:08:10 -0400

Hi Guodong,

On Fri, Jun 24, 2022 at 09:36:59PM +0800, Guodong Liu wrote:
> Function bias_combo getter/setters already handle all cases advanced
> drive
> configuration, include drive for I2C related pins.

This commit message could be improved. I suggest using the following
commit
message:

The bias_combo getter/setter is already able to handle advanced drive
configuration, which is the reason commit 353d2ef77f2b ("dt-bindings:
pinctrl:
mt8192: Use generic bias instead of pull-*-adv") dropped the pull-up-
adv and
pull-down-adv properties from the binding. With those properties
removed,
there's no longer any use for the adv_pull callbacks, so drop them.

When commit info include info "commit 353d2ef77f2b", local check pathch
will report "WARNING:UNKNOWN_COMMIT_IO: Unknow commit id
'353d2ef77f2b'", so isn't add those commit info here. thanks!
> 
> Signed-off-by: Guodong Liu <guodong.liu@...iatek.com>

Reviewed-by: Nícolas F. R. A. Prado <nfraprado@...labora.com>
Tested-by: Nícolas F. R. A. Prado <nfraprado@...labora.com>

Thanks,
Nícolas