linux-kernel - Re: [PATCH v3 6/9] tty: n_gsm: fix deadlock and link starvation in outgoing data path

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 27 Jun 2022 13:54:53 +0200
From:   Greg KH <gregkh@...uxfoundation.org>
To:     "Starke, Daniel" <daniel.starke@...mens.com>
Cc:     "linux-serial@...r.kernel.org" <linux-serial@...r.kernel.org>,
        "jirislaby@...nel.org" <jirislaby@...nel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v3 6/9] tty: n_gsm: fix deadlock and link starvation in
 outgoing data path

On Thu, Jun 23, 2022 at 12:26:27PM +0000, Starke, Daniel wrote:
> > This is a bit huge for stable backports, especially given that a huge
> > number of the previous stable backports have totally failed and no one
> > has submitted new versions.
> > 
> > So why is this needed for stable?  Same for all of these in the series...
> 
> Given the fact that these are all bug fixes I assumed that these are also
> relevant for backporting. Maybe only in the more recent stable releases
> if there are issues with the merges.
> I do not mind removing the stable kernel reference and keep these changes
> only for mainline. So please let me know your preference.
> Should I resubmit the patches without stable reference?

Please read the stable kernel rules for what is, and is not allowed.
Generally a patch that does:
	drivers/tty/n_gsm.c | 410 ++++++++++++++++++++++++++++++--------------
is not allowed.

Please sort by what is stable fixes, and what is not.  Given that you
don't seem to want to backport patches to older stable kernels when they
fail to apply, why are any of these needed in stable kernels if the
older ones are not also going to be merged there?

thanks,

greg k-h