linux-kernel - Re: [PATCH] drm/amd/display: change to_dal_irq_source_dnc32() storage class specifier to static

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 27 Jun 2022 09:20:13 -0400
From:   Aurabindo Pillai <aurabindo.pillai@....com>
To:     Tom Rix <trix@...hat.com>, harry.wentland@....com,
        sunpeng.li@....com, Rodrigo.Siqueira@....com,
        alexander.deucher@....com, christian.koenig@....com,
        Xinhui.Pan@....com, airlied@...ux.ie, daniel@...ll.ch,
        Qingqing.Zhuo@....com, mario.limonciello@....com,
        nicholas.kazlauskas@....com, maira.canal@....br
Cc:     amd-gfx@...ts.freedesktop.org, dri-devel@...ts.freedesktop.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] drm/amd/display: change to_dal_irq_source_dnc32() storage
 class specifier to static



On 2022-06-26 10:46, Tom Rix wrote:
> sparse reports
> drivers/gpu/drm/amd/amdgpu/../display/dc/irq/dcn32/irq_service_dcn32.c:39:20: warning: symbol 'to_dal_irq_source_dcn32' was not declared. Should it be static?
> 
> to_dal_irq_source_dnc32() is only referenced in irq_service_dnc32.c, so change its
> storage class specifier to static.
> 
> Fixes: 0efd4374f6b4 ("drm/amd/display: add dcn32 IRQ changes")
> Signed-off-by: Tom Rix <trix@...hat.com>
> ---
>   drivers/gpu/drm/amd/display/dc/irq/dcn32/irq_service_dcn32.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/amd/display/dc/irq/dcn32/irq_service_dcn32.c b/drivers/gpu/drm/amd/display/dc/irq/dcn32/irq_service_dcn32.c
> index 3a213ca2f077..b1012fa1977b 100644
> --- a/drivers/gpu/drm/amd/display/dc/irq/dcn32/irq_service_dcn32.c
> +++ b/drivers/gpu/drm/amd/display/dc/irq/dcn32/irq_service_dcn32.c
> @@ -36,7 +36,7 @@
>   
>   #define DCN_BASE__INST0_SEG2                       0x000034C0
>   
> -enum dc_irq_source to_dal_irq_source_dcn32(
> +static enum dc_irq_source to_dal_irq_source_dcn32(
>   		struct irq_service *irq_service,
>   		uint32_t src_id,
>   		uint32_t ext_id)

Reviewed-by: Aurabindo Pillai <aurabindo.pillai@....com>