linux-kernel - Re: [PATCH] drm/stm: ltdc: disable all layers before crtc shutdown

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <51843c58-82ac-6b81-99b6-75c267ff1a59@foss.st.com>
Date:   Mon, 27 Jun 2022 16:10:54 +0200
From:   Philippe CORNU <philippe.cornu@...s.st.com>
To:     Yannick Fertre <yannick.fertre@...s.st.com>,
        Raphael Gallais-Pou <raphael.gallais-pou@...s.st.com>,
        David Airlie <airlied@...ux.ie>,
        Daniel Vetter <daniel@...ll.ch>,
        Maxime Coquelin <mcoquelin.stm32@...il.com>,
        Alexandre Torgue <alexandre.torgue@...s.st.com>,
        <dri-devel@...ts.freedesktop.org>,
        <linux-stm32@...md-mailman.stormreply.com>,
        <linux-arm-kernel@...ts.infradead.org>,
        <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] drm/stm: ltdc: disable all layers before crtc shutdown



On 6/3/22 15:41, Yannick Fertre wrote:
> All plans must be disabled before the CRTC shutdown helping
> the crtc to restart from a clean situation (without unwanted
> planes already enable).
> 
> Signed-off-by: Yannick Fertre <yannick.fertre@...s.st.com>
> ---
>   drivers/gpu/drm/stm/ltdc.c | 6 ++++++
>   1 file changed, 6 insertions(+)
> 
> diff --git a/drivers/gpu/drm/stm/ltdc.c b/drivers/gpu/drm/stm/ltdc.c
> index 6bd45df8f5a7..eeefc3260c07 100644
> --- a/drivers/gpu/drm/stm/ltdc.c
> +++ b/drivers/gpu/drm/stm/ltdc.c
> @@ -787,11 +787,17 @@ static void ltdc_crtc_atomic_disable(struct drm_crtc *crtc,
>   {
>   	struct ltdc_device *ldev = crtc_to_ltdc(crtc);
>   	struct drm_device *ddev = crtc->dev;
> +	int layer_index = 0;
>   
>   	DRM_DEBUG_DRIVER("\n");
>   
>   	drm_crtc_vblank_off(crtc);
>   
> +	/* Disable all layers */
> +	for (layer_index = 0; layer_index < ldev->caps.nb_layers; layer_index++)
> +		regmap_write_bits(ldev->regmap, LTDC_L1CR + layer_index * LAY_OFS,
> +				  LXCR_CLUTEN | LXCR_LEN, 0);
> +
>   	/* disable IRQ */
>   	regmap_clear_bits(ldev->regmap, LTDC_IER, IER_RRIE | IER_FUIE | IER_TERRIE);
>   

Dear Yannick,
Many thanks for your patch,
Applied on drm-misc-next.
Have a good day
Philippe :-)