linux-kernel - Re: [PATCH] watchdog: sp805_wdt: add arm cmsdk apb wdt support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <e640e330-5318-e60e-d3e3-16d9bd7b289a@roeck-us.net>
Date:   Mon, 27 Jun 2022 07:13:37 -0700
From:   Guenter Roeck <linux@...ck-us.net>
To:     Bing Fan <hptsfb@...il.com>, wim@...ux-watchdog.org
Cc:     linux-watchdog@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] watchdog: sp805_wdt: add arm cmsdk apb wdt support

On 6/23/22 19:24, Bing Fan wrote:
> From: Bing Fan <tombinfan@...cent.com>
> 
> Support arm CMSDK ip apb watchdog device.
> Description details of this device can be found in the
> document DDI0479D_m_class_processor_system_r1p1_trm.pdf
> on the arm's document web. Which periphid is 0x001bb824.
> The registers are basically the same as the 805, just a
> few more: Periphid4/5/6/7 with offset 0xFD0/0xFD4/0xFD8/0xFDC.
> For the register description of arm,sp805, please refer
> to the document DDI0270-arm-sp805.pdf.
> 
> Signed-off-by: Bing Fan <tombinfan@...cent.com>

Reviewed-by: Guenter Roeck <linux@...ck-us.net>

> ---
>   drivers/watchdog/sp805_wdt.c | 5 +++++
>   1 file changed, 5 insertions(+)
> 
> diff --git a/drivers/watchdog/sp805_wdt.c b/drivers/watchdog/sp805_wdt.c
> index f9479a3fe2a6..78ba36689eec 100644
> --- a/drivers/watchdog/sp805_wdt.c
> +++ b/drivers/watchdog/sp805_wdt.c
> @@ -1,3 +1,4 @@
> +// SPDX-License-Identifier: GPL-2.0+
>   /*
>    * drivers/char/watchdog/sp805-wdt.c
>    *
> @@ -341,6 +342,10 @@ static const struct amba_id sp805_wdt_ids[] = {
>   		.id	= 0x00141805,
>   		.mask	= 0x00ffffff,
>   	},
> +	{
> +		.id     = 0x001bb824,
> +		.mask   = 0x00ffffff,
> +	},
>   	{ 0, 0 },
>   };
>