linux-kernel - Re: [PATCH] mm/kasan: Fix null pointer dereference warning in qlink_to

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <dddd7c7e-3c60-f916-2947-4ee00a765574@gmail.com>
Date:   Mon, 27 Jun 2022 17:30:58 +0300
From:   Andrey Ryabinin <ryabinin.a.a@...il.com>
To:     Gautam Menghani <gautammenghani201@...il.com>, glider@...gle.com,
        andreyknvl@...il.com, dvyukov@...gle.com,
        vincenzo.frascino@....com, akpm@...ux-foundation.org
Cc:     kasan-dev@...glegroups.com, linux-mm@...ck.org,
        linux-kernel@...r.kernel.org, skhan@...uxfoundation.org
Subject: Re: [PATCH] mm/kasan: Fix null pointer dereference warning in
 qlink_to_cache()



On 6/26/22 20:03, Gautam Menghani wrote:
> The function virt_to_slab() declared in slab.h can return NULL if the
> address does not belong to a slab. This case is not handled in the
> function qlink_to_cache() in the file quarantine.c, which can cause a
> NULL pointer dereference in "virt_to_slab(qlink)->slab_cache". 

qlink is always slab address, so I don't think this patch makes sense.
NAK.