linux-kernel - Re: [PATCH 5.18 097/181] Revert "net/tls: fix tls_sk_proto

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20220627085728.643737fb@kernel.org>
Date:   Mon, 27 Jun 2022 08:57:28 -0700
From:   Jakub Kicinski <kuba@...nel.org>
To:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc:     linux-kernel@...r.kernel.org, stable@...r.kernel.org,
        John Fastabend <john.fastabend@...il.com>,
        Paolo Abeni <pabeni@...hat.com>,
        Sasha Levin <sashal@...nel.org>
Subject: Re: [PATCH 5.18 097/181] Revert "net/tls: fix tls_sk_proto_close
 executed repeatedly"

On Mon, 27 Jun 2022 17:50:31 +0200 Greg Kroah-Hartman wrote:
> On Mon, Jun 27, 2022 at 08:33:13AM -0700, Jakub Kicinski wrote:
> > On Mon, 27 Jun 2022 13:21:10 +0200 Greg Kroah-Hartman wrote:  
> > > From: Jakub Kicinski <kuba@...nel.org>
> > > 
> > > [ Upstream commit 1b205d948fbb06a7613d87dcea0ff5fd8a08ed91 ]
> > > 
> > > This reverts commit 69135c572d1f84261a6de2a1268513a7e71753e2.
> > > 
> > > This commit was just papering over the issue, ULP should not
> > > get ->update() called with its own sk_prot. Each ULP would
> > > need to add this check.
> > > 
> > > Fixes: 69135c572d1f ("net/tls: fix tls_sk_proto_close executed repeatedly")
> > > Signed-off-by: Jakub Kicinski <kuba@...nel.org>  
> > 
> > Mm? How did 69135c572d1f get into stableh? 
> > I reverted it before it hit Linus's tree.
> > Don't see the notification about it either.  
> 
> It is commit 075/181 in this series as you can see here:
> 	https://lore.kernel.org/r/20220627111946.738369250@linuxfoundation.org

Argh, I forgot I'm not gonna get CCed if my tags aren't on the
commit in question, sorry for the confusion.

So I expected patches 075 and 097 would just get dropped since
they are in the same series and are canceling each other out. 
But I guess people may edit reverts so you prefer not to 
automatically do that?