linux-kernel - Re: [PATCH] clk: bcm: rpi: Fix error handling of raspberrypi_fw_get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <7656fa2c-590a-8f0f-03ef-904e4f186c82@gmail.com>
Date:   Mon, 27 Jun 2022 09:24:51 -0700
From:   Florian Fainelli <f.fainelli@...il.com>
To:     Stefan Wahren <stefan.wahren@...e.com>,
        Florian Fainelli <f.fainelli@...il.com>,
        Michael Turquette <mturquette@...libre.com>,
        Stephen Boyd <sboyd@...nel.org>
Cc:     bcm-kernel-feedback-list@...adcom.com,
        Maxime Ripard <maxime@...no.tech>, linux-clk@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] clk: bcm: rpi: Fix error handling of
 raspberrypi_fw_get_rate

On 6/25/22 01:36, Stefan Wahren wrote:
> The function raspberrypi_fw_get_rate (e.g. used for the recalc_rate
> hook) can fail to get the clock rate from the firmware. In this case
> we cannot return a signed error value, which would be casted to
> unsigned long. Fix this by returning 0 instead.
> 
> Signed-off-by: Stefan Wahren <stefan.wahren@...e.com>

Fixes: 4e85e535e6cc ("clk: bcm283x: add driver interfacing with 
Raspberry Pi's firmware")

Acked-by: Florian Fainelli <f.fainelli@...il.com>
-- 
Florian