linux-kernel - Re: [PATCH] of: device - Remove duplicate 'of' in two places.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20220627173825.GA2637590-robh@kernel.org>
Date:   Mon, 27 Jun 2022 11:38:25 -0600
From:   Rob Herring <robh@...nel.org>
To:     Jiang Jian <jiangjian@...rlc.com>
Cc:     frowand.list@...il.com, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] of: device - Remove duplicate 'of' in two places.

On Tue, Jun 21, 2022 at 11:42:22PM +0800, Jiang Jian wrote:
> file: ./drivers/of/device.c
> line: 22
>  * @matches: array of of device match structures to search in
> changed to
>  * @matches: array of device match structures to search in
> 
> Signed-off-by: Jiang Jian <jiangjian@...rlc.com>
> ---
>  drivers/of/device.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/of/device.c b/drivers/of/device.c
> index 874f031442dc..1582388156a9 100644
> --- a/drivers/of/device.c
> +++ b/drivers/of/device.c
> @@ -19,7 +19,7 @@
>  
>  /**
>   * of_match_device - Tell if a struct device matches an of_device_id list
> - * @matches: array of of device match structures to search in
> + * @matches: array of device match structures to search in

Maybe that was supposed to be 'of OF device match'? 

But really, something like 'NULL terminated array of struct of_device_id 
entries to search' would be better.

>   * @dev: the of device structure to match against

Like 'of' here.

>   *
>   * Used by a driver to check whether an platform_device present in the
> -- 
> 2.17.1
> 
>