linux-kernel - Re: [RESEND PATCH v4 1/2] highmem: Make __kunmap

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 27 Jun 2022 11:19:27 -0700
From:   Andrew Morton <akpm@...ux-foundation.org>
To:     "Fabio M. De Francesco" <fmdefrancesco@...il.com>
Cc:     David Sterba <dsterba@...e.com>, Chris Mason <clm@...com>,
        Josef Bacik <josef@...icpanda.com>,
        Nick Terrell <terrelln@...com>, linux-btrfs@...r.kernel.org,
        linux-kernel@...r.kernel.org, Ira Weiny <ira.weiny@...el.com>,
        Matthew Wilcox <willy@...radead.org>,
        Kees Cook <keescook@...omium.org>,
        Sebastian Andrzej Siewior <bigeasy@...utronix.de>,
        "James E . J . Bottomley" <James.Bottomley@...senpartnership.com>,
        Helge Deller <deller@....de>,
        John David Anglin <dave.anglin@...l.net>,
        linux-parisc@...r.kernel.org, David Sterba <dsterba@...e.cz>
Subject: Re: [RESEND PATCH v4 1/2] highmem: Make __kunmap_{local,atomic}()
 take "const void *"

On Mon, 27 Jun 2022 19:02:31 +0200 "Fabio M. De Francesco" <fmdefrancesco@...il.com> wrote:

> > v1->v2: Change the commit message to clearly explain why these functions
> >         should require pointers to const void. The fundamental argument
> >         behind the commit message changes is semantic correctness.
> >         Obviously, there are no changes to the code.
> >         Many thanks to David Sterba and Ira Weiny for suggestions and
> >         reviews.
> >
> >  arch/parisc/include/asm/cacheflush.h |  6 +++---
> >  arch/parisc/kernel/cache.c           |  2 +-
> >  include/linux/highmem-internal.h     | 10 +++++-----
> >  mm/highmem.c                         |  2 +-
> >  4 files changed, 10 insertions(+), 10 deletions(-)
> 
> @Andrew:
> 
> Ira Weiny asked David Sterba for taking this patch through his tree because 
> it is a pre-requisite for a patch to fs/btrfs. He agreed with the above-
> mentioned suggestion, however I suppose that an ACK by you is needed.
> 
> Can you please take a look at this patch and say what you think about it?

Looks OK to me.  It's one of those "if it compiles, it's good" things.

I don't believe the patch has ever appeared on linux-mm?  Please send
it there for some review then go ahead and merge it up.