[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <20220627113812.08ae31f0@kernel.org>
Date: Mon, 27 Jun 2022 11:38:12 -0700
From: Jakub Kicinski <kuba@...nel.org>
To: Andrew Lunn <andrew@...n.ch>
Cc: Praghadeesh T K S <praghadeeshthevendria@...il.com>,
Rain River <rain.1986.08.12@...il.com>,
Zhu Yanjun <zyjzyj2000@...il.com>,
"David S. Miller" <davem@...emloft.net>,
Eric Dumazet <edumazet@...gle.com>,
Paolo Abeni <pabeni@...hat.com>, netdev@...r.kernel.org,
linux-kernel@...r.kernel.org, skhan@...uxfoundation.org,
praghadeeshtks@...omail.in,
linux-kernel-mentees@...ts.linuxfoundation.org
Subject: Re: [PATCH] net: ethernet/nvidia: fix possible condition with no
effect
On Sun, 26 Jun 2022 13:08:37 +0200 Andrew Lunn wrote:
> On Sun, Jun 26, 2022 at 10:35:39AM +0000, Praghadeesh T K S wrote:
> > Fix Coccinelle bug, removed condition with no effect.
>
> This is not a coccinelle bug. If it was, you would be patching
> coccinelle, not the kernel.
I'd say the commit message is better than the commit ;)
Praghadeesh, could you fix Coccinelle to avoid matching:
if (/* case 1 */) {
/* BLOCK 1*/
} else (/* case 2 */ {
/* BLOCK 2 */
} else {
/* default == BLOCK 2 */
}
Because 99% of the time that construct is intentional.
Powered by blists - more mailing lists