linux-kernel - Re: [PATCH v2] nvme-pci: add NVME_QUIRK_BOGUS_NID for ADATA XPG SX6000LNP (AKA SPECTRIX S40G)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <00568db1-359d-338f-247e-f9e16d0cf9f3@nvidia.com>
Date:   Mon, 27 Jun 2022 20:43:50 +0000
From:   Chaitanya Kulkarni <chaitanyak@...dia.com>
To:     Pablo Greco <pgreco@...tosproject.org>
CC:     "stable@...r.kernel.org" <stable@...r.kernel.org>,
        Keith Busch <kbusch@...nel.org>, Jens Axboe <axboe@...com>,
        Christoph Hellwig <hch@....de>,
        Sagi Grimberg <sagi@...mberg.me>,
        "linux-nvme@...ts.infradead.org" <linux-nvme@...ts.infradead.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2] nvme-pci: add NVME_QUIRK_BOGUS_NID for ADATA XPG
 SX6000LNP (AKA SPECTRIX S40G)

On 6/25/22 05:15, Pablo Greco wrote:
> ADATA XPG SPECTRIX S40G drives report bogus eui64 values that appear to
> be the same across drives in one system. Quirk them out so they are
> not marked as "non globally unique" duplicates.
> 

Can be written with moving "not" to the 2nd line, if anyone cares :-

ADATA XPG SPECTRIX S40G drives report bogus eui64 values that appear to
be the same across drives in one system. Quirk them out so they are not
marked as "non globally unique" duplicates.

> Before:
> [    2.258919] nvme nvme1: pci function 0000:06:00.0
> [    2.264898] nvme nvme2: pci function 0000:05:00.0
> [    2.323235] nvme nvme1: failed to set APST feature (2)
> [    2.326153] nvme nvme2: failed to set APST feature (2)
> [    2.333935] nvme nvme1: allocated 64 MiB host memory buffer.
> [    2.336492] nvme nvme2: allocated 64 MiB host memory buffer.
> [    2.339611] nvme nvme1: 7/0/0 default/read/poll queues
> [    2.341805] nvme nvme2: 7/0/0 default/read/poll queues
> [    2.346114]  nvme1n1: p1
> [    2.347197] nvme nvme2: globally duplicate IDs for nsid 1
> After:
> [    2.427715] nvme nvme1: pci function 0000:06:00.0
> [    2.427771] nvme nvme2: pci function 0000:05:00.0
> [    2.488154] nvme nvme2: failed to set APST feature (2)
> [    2.489895] nvme nvme1: failed to set APST feature (2)
> [    2.498773] nvme nvme2: allocated 64 MiB host memory buffer.
> [    2.500587] nvme nvme1: allocated 64 MiB host memory buffer.
> [    2.504113] nvme nvme2: 7/0/0 default/read/poll queues
> [    2.507026] nvme nvme1: 7/0/0 default/read/poll queues
> [    2.509467] nvme nvme2: Ignoring bogus Namespace Identifiers
> [    2.512804] nvme nvme1: Ignoring bogus Namespace Identifiers
> [    2.513698]  nvme1n1: p1
> 
> Signed-off-by: Pablo Greco <pgreco@...tosproject.org>
> Cc: <stable@...r.kernel.org>
> ---

Looks good.

Reviewed-by: Chaitanya Kulkarni <kch@...dia.com>

-ck