linux-kernel - Re: [PATCH v9 5/8] perf tool: Add support for HiSilicon PCIe Tune and Trace device driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20220627020256.GB143063@leoy-ThinkPad-X240s>
Date:   Mon, 27 Jun 2022 10:02:56 +0800
From:   Leo Yan <leo.yan@...aro.org>
To:     Yicong Yang <yangyicong@...ilicon.com>
Cc:     gregkh@...uxfoundation.org, alexander.shishkin@...ux.intel.com,
        james.clark@....com, will@...nel.org, robin.murphy@....com,
        acme@...nel.org, jonathan.cameron@...wei.com,
        john.garry@...wei.com, helgaas@...nel.org,
        lorenzo.pieralisi@....com, mathieu.poirier@...aro.org,
        suzuki.poulose@....com, mark.rutland@....com, joro@...tes.org,
        shameerali.kolothum.thodi@...wei.com, peterz@...radead.org,
        mingo@...hat.com, linux-kernel@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org, linux-pci@...r.kernel.org,
        linux-perf-users@...r.kernel.org, iommu@...ts.linux-foundation.org,
        prime.zeng@...wei.com, liuqi115@...wei.com,
        zhangshaokun@...ilicon.com, linuxarm@...wei.com
Subject: Re: [PATCH v9 5/8] perf tool: Add support for HiSilicon PCIe Tune
 and Trace device driver

On Mon, Jun 06, 2022 at 07:55:52PM +0800, Yicong Yang wrote:
> From: Qi Liu <liuqi115@...wei.com>
> 
> HiSilicon PCIe tune and trace device (PTT) could dynamically tune
> the PCIe link's events, and trace the TLP headers).
> 
> This patch add support for PTT device in perf tool, so users could
> use 'perf record' to get TLP headers trace data.
> 
> Signed-off-by: Qi Liu <liuqi115@...wei.com>
> Signed-off-by: Yicong Yang <yangyicong@...ilicon.com>

Just one minor comment.

[...]

> diff --git a/tools/perf/util/hisi-ptt.h b/tools/perf/util/hisi-ptt.h
> new file mode 100644
> index 000000000000..2db9b4056214
> --- /dev/null
> +++ b/tools/perf/util/hisi-ptt.h
> @@ -0,0 +1,19 @@
> +/* SPDX-License-Identifier: GPL-2.0 */
> +/*
> + * HiSilicon PCIe Trace and Tuning (PTT) support
> + * Copyright (c) 2022 HiSilicon Technologies Co., Ltd.
> + */
> +
> +#ifndef INCLUDE__PERF_HISI_PTT_H__
> +#define INCLUDE__PERF_HISI_PTT_H__
> +
> +#define HISI_PTT_PMU_NAME		"hisi_ptt"
> +#define HISI_PTT_AUXTRACE_PRIV_SIZE	sizeof(u64)
> +
> +struct auxtrace_record *hisi_ptt_recording_init(int *err,
> +						struct perf_pmu *hisi_ptt_pmu);
> +
> +int hisi_ptt_process_auxtrace_info(union perf_event *event,
> +				   struct perf_session *session);

The function hisi_ptt_process_auxtrace_info() is introduced by next
patch for support PTT decoding, for good practice (e.g. keep
bisection), it's good to introduce function declaration and definition
in one patch.

With this fixing, this patch looks good to me:

Reviewed-by: Leo Yan <leo.yan@...aro.org>

> +
> +#endif
> -- 
> 2.24.0