[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20220627221257.GA3046298-robh@kernel.org>
Date: Mon, 27 Jun 2022 16:12:57 -0600
From: Rob Herring <robh@...nel.org>
To: Jean-Jacques Hiblot <jjhiblot@...phandler.com>
Cc: pavel@....cz, sven.schwermer@...ruptive-technologies.com,
krzysztof.kozlowski+dt@...aro.org, johan+linaro@...nel.org,
marijn.suijten@...ainline.org, bjorn.andersson@...aro.org,
andy.shevchenko@...il.com, linux-leds@...r.kernel.org,
devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 3/4] dt-bindings: leds: Add binding for a multicolor
group of LEDs
On Wed, Jun 15, 2022 at 05:49:17PM +0200, Jean-Jacques Hiblot wrote:
> This allows to group multiple monochromatic LEDs into a multicolor
> LED, e.g. RGB LEDs.
>
> Signed-off-by: Jean-Jacques Hiblot <jjhiblot@...phandler.com>
> ---
> .../bindings/leds/leds-group-multicolor.yaml | 94 +++++++++++++++++++
> 1 file changed, 94 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/leds/leds-group-multicolor.yaml
>
> diff --git a/Documentation/devicetree/bindings/leds/leds-group-multicolor.yaml b/Documentation/devicetree/bindings/leds/leds-group-multicolor.yaml
> new file mode 100644
> index 000000000000..30a67985ae33
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/leds/leds-group-multicolor.yaml
> @@ -0,0 +1,94 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/leds/leds-group-multicolor.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Multi-color LED built with monochromatic LEDs
> +
> +maintainers:
> + - Jean-Jacques Hiblot <jjhiblot@...phandler.com>
> +
> +description: |
> + This driver combines several monochromatic LEDs into one multi-color
> + LED using the multicolor LED class.
> +
> +properties:
> + compatible:
> + const: leds-group-multicolor
> +
> + multi-led:
> + type: object
> +
> + patternProperties:
> + "^led-[0-9a-z]+$":
> + type: object
> + $ref: common.yaml#
> +
> + additionalProperties: false
> +
> + properties:
> + leds:
Not a standard property. What is the type?
Really, just do a GPIO multi-color LED binding similar to the PWM one
rather than adding this layer. I suppose you could combine LEDs from all
different controllers, but that seems somewhat unlikely to me.
Rob
Powered by blists - more mailing lists