linux-kernel - RE: [PATCH][next] treewide: uapi: Replace zero-length arrays with flexible-array members

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <62ba2fced98ed_103a0e29448@dwillia2-xfh.notmuch>
Date:   Mon, 27 Jun 2022 15:31:42 -0700
From:   Dan Williams <dan.j.williams@...el.com>
To:     "Gustavo A. R. Silva" <gustavoars@...nel.org>,
        Kees Cook <keescook@...omium.org>,
        <linux-kernel@...r.kernel.org>
CC:     <x86@...nel.org>, <dm-devel@...hat.com>,
        <linux-m68k@...ts.linux-m68k.org>, <linux-mips@...r.kernel.org>,
        <linux-s390@...r.kernel.org>, <kvm@...r.kernel.org>,
        <intel-gfx@...ts.freedesktop.org>,
        <dri-devel@...ts.freedesktop.org>, <netdev@...r.kernel.org>,
        <bpf@...r.kernel.org>, <linux-btrfs@...r.kernel.org>,
        <linux-can@...r.kernel.org>, <linux-fsdevel@...r.kernel.org>,
        <linux1394-devel@...ts.sourceforge.net>,
        <io-uring@...r.kernel.org>, <lvs-devel@...r.kernel.org>,
        <linux-mtd@...ts.infradead.org>, <kasan-dev@...glegroups.com>,
        <linux-mmc@...r.kernel.org>, <nvdimm@...ts.linux.dev>,
        <netfilter-devel@...r.kernel.org>, <coreteam@...filter.org>,
        <linux-perf-users@...r.kernel.org>, <linux-raid@...r.kernel.org>,
        <linux-sctp@...r.kernel.org>,
        <linux-stm32@...md-mailman.stormreply.com>,
        <linux-arm-kernel@...ts.infradead.org>,
        <linux-scsi@...r.kernel.org>, <target-devel@...r.kernel.org>,
        <linux-usb@...r.kernel.org>,
        <virtualization@...ts.linux-foundation.org>,
        <v9fs-developer@...ts.sourceforge.net>,
        <linux-rdma@...r.kernel.org>, <alsa-devel@...a-project.org>,
        "Gustavo A. R. Silva" <gustavoars@...nel.org>,
        <linux-hardening@...r.kernel.org>
Subject: RE: [PATCH][next] treewide: uapi: Replace zero-length arrays with
 flexible-array members

Gustavo A. R. Silva wrote:
> There is a regular need in the kernel to provide a way to declare
> having a dynamically sized set of trailing elements in a structure.
> Kernel code should always use “flexible array members”[1] for these
> cases. The older style of one-element or zero-length arrays should
> no longer be used[2].
> 
> This code was transformed with the help of Coccinelle:
> (linux-5.19-rc2$ spatch --jobs $(getconf _NPROCESSORS_ONLN) --sp-file script.cocci --include-headers --dir . > output.patch)
> 
> @@
> identifier S, member, array;
> type T1, T2;
> @@
> 
> struct S {
>   ...
>   T1 member;
>   T2 array[
> - 0
>   ];
> };
> 
> -fstrict-flex-arrays=3 is coming and we need to land these changes
> to prevent issues like these in the short future:
> 
> ../fs/minix/dir.c:337:3: warning: 'strcpy' will always overflow; destination buffer has size 0,
> but the source string has length 2 (including NUL byte) [-Wfortify-source]
> 		strcpy(de3->name, ".");
> 		^
> 
> Since these are all [0] to [] changes, the risk to UAPI is nearly zero. If
> this breaks anything, we can use a union with a new member name.
> 
> [1] https://en.wikipedia.org/wiki/Flexible_array_member
> [2] https://www.kernel.org/doc/html/v5.16/process/deprecated.html#zero-length-and-one-element-arrays
> 
> Link: https://github.com/KSPP/linux/issues/78
> Build-tested-by: https://lore.kernel.org/lkml/62b675ec.wKX6AOZ6cbE71vtF%25lkp@intel.com/
> Signed-off-by: Gustavo A. R. Silva <gustavoars@...nel.org>
> ---
> Hi all!
> 
> JFYI: I'm adding this to my -next tree. :)
> 
[..]
>  include/uapi/linux/ndctl.h                    | 10 +--

For ndctl.h

Acked-by: Dan Williams <dan.j.williams@...el.com>