linux-kernel - Re: [PATCH v2 03/11] clk: fixed-factor: Introduce *clk_hw_register_fixed_factor_parent

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20220627223603.5dxxbqqqjddkgdnb@SoMainline.org>
Date:   Tue, 28 Jun 2022 00:36:03 +0200
From:   Marijn Suijten <marijn.suijten@...ainline.org>
To:     Stephen Boyd <sboyd@...nel.org>
Cc:     Dmitry Baryshkov <dmitry.baryshkov@...aro.org>,
        phone-devel@...r.kernel.org, ~postmarketos/upstreaming@...ts.sr.ht,
        AngeloGioacchino Del Regno 
        <angelogioacchino.delregno@...ainline.org>,
        Konrad Dybcio <konrad.dybcio@...ainline.org>,
        Martin Botka <martin.botka@...ainline.org>,
        Jami Kettunen <jami.kettunen@...ainline.org>,
        Michael Turquette <mturquette@...libre.com>,
        Rob Clark <robdclark@...il.com>,
        Abhinav Kumar <quic_abhinavk@...cinc.com>,
        Sean Paul <sean@...rly.run>, David Airlie <airlied@...ux.ie>,
        Daniel Vetter <daniel@...ll.ch>,
        Rajeev Nandan <quic_rajeevny@...cinc.com>,
        Vladimir Lypak <vladimir.lypak@...il.com>,
        Arnd Bergmann <arnd@...db.de>,
        Jonathan Marek <jonathan@...ek.ca>, linux-clk@...r.kernel.org,
        linux-kernel@...r.kernel.org, linux-arm-msm@...r.kernel.org,
        dri-devel@...ts.freedesktop.org, freedreno@...ts.freedesktop.org
Subject: Re: [PATCH v2 03/11] clk: fixed-factor: Introduce
 *clk_hw_register_fixed_factor_parent_hw()

On 2022-06-10 12:01:10, Stephen Boyd wrote:
> Quoting Marijn Suijten (2022-06-10 00:46:32)
> > On 2022-06-09 15:12:09, Stephen Boyd wrote:
> > > Quoting Dmitry Baryshkov (2022-06-02 03:20:19)
> > > > On Thu, 2 Jun 2022 at 01:07, Marijn Suijten
> > > > <marijn.suijten@...ainline.org> wrote:
> > > > > diff --git a/drivers/clk/clk-fixed-factor.c b/drivers/clk/clk-fixed-factor.c
> > > > > index 54942d758ee6..fabb98d0cdb2 100644
> > > > > --- a/drivers/clk/clk-fixed-factor.c
> > > > > +++ b/drivers/clk/clk-fixed-factor.c
> > > > > @@ -148,17 +151,50 @@ struct clk_hw *devm_clk_hw_register_fixed_factor_index(struct device *dev,
> > > > >                 const char *name, unsigned int index, unsigned long flags,
> > > > >                 unsigned int mult, unsigned int div)
> > > > >  {
> > > > > -       return __clk_hw_register_fixed_factor(dev, NULL, name, NULL, index,
> > > > > -                                             flags, mult, div, true);
> > > > > +       return __clk_hw_register_fixed_factor(dev, NULL, name, NULL, NULL,
> > > > > +                                             index, flags, mult, div, true);
> > > > 
> > > > Here (and several times later) you are inserting an argument and then
> > > > moving arguments to the next line. My slight preference would be to
> > > > just insert the arg (and maybe break the line if it gets too long) w/o
> > > > touching the next lines.
> > 
> > That'll definitely look odd, as we'll end up with index floating on a
> > single line, all on its own.
> 
> Pretty sure Dmitry is suggesting to make the line longer, not put the
> index on a line by itself. Ignore the 80-column limit.

There's a "(and maybe break the line if it gets too long)" in there, but
it's ugly especially for short (ie. "0,") arguments.  I'm following your
request to ignore 80-columns as a limit.

Will resend this after being able to physically build-test it tomorrow,
thanks!

- Marijn