lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 27 Jun 2022 15:53:55 -0700 From: Josh Don <joshdon@...gle.com> To: Abel Wu <wuyun.abel@...edance.com> Cc: Peter Zijlstra <peterz@...radead.org>, Mel Gorman <mgorman@...e.de>, Vincent Guittot <vincent.guittot@...aro.org>, Chen Yu <yu.c.chen@...el.com>, Tim Chen <tim.c.chen@...ux.intel.com>, K Prateek Nayak <kprateek.nayak@....com>, "Gautham R . Shenoy" <gautham.shenoy@....com>, linux-kernel <linux-kernel@...r.kernel.org> Subject: Re: [PATCH v4 1/7] sched/fair: default to false in test_idle_cores On Sun, Jun 19, 2022 at 5:05 AM Abel Wu <wuyun.abel@...edance.com> wrote: > > It's uncertain whether idle cores exist or not if shared sched-domains > are not ready, so returning "no idle cores" usually makes sense. > > While __update_idle_core() is an exception, it checks status of this > core and set to shared sched-domain if necessary. So the whole logic > depends on the existence of shared domain, and can bail out early if > it isn't available. Modern compilers seems capable of handling such > cases, so remove the tricky self-defined default return value. I don't think the compiler will be able to bail out of the smt iteration early, since it'll have to do another rcu dereference for the sd_llc in set(). But I also don't think this case needs optimization, since it should be transient while the domain isn't ready. Reviewed-by: Josh Don <joshdon@...gle.com>
Powered by blists - more mailing lists