linux-kernel - RE: [PATCH 6/8] dmaengine: hisilicon: Add dfx feature for hisi dma driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 27 Jun 2022 06:55:25 +0000
From:   haijie <haijie1@...wei.com>
To:     kernel test robot <lkp@...el.com>,
        "vkoul@...nel.org" <vkoul@...nel.org>,
        "Wangzhou (B)" <wangzhou1@...ilicon.com>
CC:     "kbuild-all@...ts.01.org" <kbuild-all@...ts.01.org>,
        "dmaengine@...r.kernel.org" <dmaengine@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH 6/8] dmaengine: hisilicon: Add dfx feature for hisi dma
 driver

Hi, kernel test robot,

Thanks and this will be corrected in the next version.

-----Original Message-----
From: kernel test robot [mailto:lkp@...el.com] 
Sent: Saturday, June 25, 2022 5:37 PM
To: haijie <haijie1@...wei.com>; vkoul@...nel.org; Wangzhou (B) <wangzhou1@...ilicon.com>
Cc: kbuild-all@...ts.01.org; dmaengine@...r.kernel.org; linux-kernel@...r.kernel.org
Subject: Re: [PATCH 6/8] dmaengine: hisilicon: Add dfx feature for hisi dma driver

Hi Jie,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on vkoul-dmaengine/next] [also build test WARNING on linus/master v5.19-rc3 next-20220624] [If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch]

url:    https://github.com/intel-lab-lkp/linux/commits/Jie-Hai/dmaengine-hisilicon-Add-support-for-hisi-dma-driver/20220625-154524
base:   https://git.kernel.org/pub/scm/linux/kernel/git/vkoul/dmaengine.git next
config: microblaze-randconfig-r022-20220625
compiler: microblaze-linux-gcc (GCC) 11.3.0 reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/intel-lab-lkp/linux/commit/ffaa89af83c2321f12a2b4d87711c9e7f7e37134
        git remote add linux-review https://github.com/intel-lab-lkp/linux
        git fetch --no-tags linux-review Jie-Hai/dmaengine-hisilicon-Add-support-for-hisi-dma-driver/20220625-154524
        git checkout ffaa89af83c2321f12a2b4d87711c9e7f7e37134
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.3.0 make.cross W=1 O=build_dir ARCH=microblaze SHELL=/bin/bash drivers/dma/

If you fix the issue, kindly add following tag where applicable
Reported-by: kernel test robot <lkp@...el.com>

All warnings (new ones prefixed by >>):

>> drivers/dma/hisi_dma.c:87: warning: This comment starts with '/**', 
>> but isn't a kernel-doc comment. Refer 
>> Documentation/doc-guide/kernel-doc.rst
    * The HIP08B(HiSilicon IP08) and HIP09A(HiSilicon IP09) are DMA iEPs, they


vim +87 drivers/dma/hisi_dma.c

ffaa89af83c232 Jie Hai 2022-06-25  85
ae8a14d7255c1e Jie Hai 2022-06-25  86  /**
ae8a14d7255c1e Jie Hai 2022-06-25 @87   * The HIP08B(HiSilicon IP08) and HIP09A(HiSilicon IP09) are DMA iEPs, they
ae8a14d7255c1e Jie Hai 2022-06-25  88   * have the same pci device id but different pci revision.
ae8a14d7255c1e Jie Hai 2022-06-25  89   * Unfortunately, they have different register layouts, so two layout
ae8a14d7255c1e Jie Hai 2022-06-25  90   * enumerations are defined.
ae8a14d7255c1e Jie Hai 2022-06-25  91   */
ae8a14d7255c1e Jie Hai 2022-06-25  92  enum hisi_dma_reg_layout {
ae8a14d7255c1e Jie Hai 2022-06-25  93  	HISI_DMA_REG_LAYOUT_INVALID = 0,
ae8a14d7255c1e Jie Hai 2022-06-25  94  	HISI_DMA_REG_LAYOUT_HIP08,
ae8a14d7255c1e Jie Hai 2022-06-25  95  	HISI_DMA_REG_LAYOUT_HIP09
ae8a14d7255c1e Jie Hai 2022-06-25  96  };
7ddbde084de590 Jie Hai 2022-06-25  97  

--
0-DAY CI Kernel Test Service
https://01.org/lkp