linux-kernel - Re: [PATCH -next] rtc: rv8803: fix missing unlock on error in rv8803_set

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20220627073726.GD19026@pengutronix.de>
Date:   Mon, 27 Jun 2022 09:37:26 +0200
From:   Sascha Hauer <s.hauer@...gutronix.de>
To:     Yang Yingliang <yangyingliang@...wei.com>
Cc:     linux-kernel@...r.kernel.org, linux-rtc@...r.kernel.org,
        alexandre.belloni@...tlin.com, a.zummo@...ertech.it,
        a.fatoum@...gutronix.de
Subject: Re: [PATCH -next] rtc: rv8803: fix missing unlock on error in
 rv8803_set_time()

On Mon, Jun 27, 2022 at 03:35:49PM +0800, Yang Yingliang wrote:
> Add the missing unlock before return from function rv8803_set_time()
> in the error handling case.
> 
> Fixes: c27fee16fab1 ("rtc: rv8803: re-initialize all Epson RX8803 registers on voltage loss")

That's not the commit breaking it. Should be:

Fixes: f8176e0bb83ff ("rtc: rv8803: initialize registers on post-probe voltage loss")

With that fixed:

Reviewed-by: Sascha Hauer <s.hauer@...gutronix.de>

Sascha

> Reported-by: Hulk Robot <hulkci@...wei.com>
> Signed-off-by: Yang Yingliang <yangyingliang@...wei.com>
> ---
>  drivers/rtc/rtc-rv8803.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/rtc/rtc-rv8803.c b/drivers/rtc/rtc-rv8803.c
> index fe1247e771b9..3527a0521e9b 100644
> --- a/drivers/rtc/rtc-rv8803.c
> +++ b/drivers/rtc/rtc-rv8803.c
> @@ -315,8 +315,10 @@ static int rv8803_set_time(struct device *dev, struct rtc_time *tm)
>  
>  	if (flags & RV8803_FLAG_V2F) {
>  		ret = rv8803_regs_reset(rv8803);
> -		if (ret)
> +		if (ret) {
> +			mutex_unlock(&rv8803->flags_lock);
>  			return ret;
> +		}
>  	}
>  
>  	ret = rv8803_write_reg(rv8803->client, RV8803_FLAG,
> -- 
> 2.25.1
> 
> 

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |