linux-kernel - Re: [PATCH v3 1/3] mfd: intel-m10-bmc: rename the local variables

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YrlkcCdYVz8Yri+j@google.com>
Date:   Mon, 27 Jun 2022 09:04:00 +0100
From:   Lee Jones <lee.jones@...aro.org>
To:     Tom Rix <trix@...hat.com>
Cc:     Tianfei Zhang <tianfei.zhang@...el.com>, yilun.xu@...el.com,
        hao.wu@...el.com, linux-kernel@...r.kernel.org,
        linux-fpga@...r.kernel.org, russell.h.weight@...el.com,
        matthew.gerlach@...ux.intel.com
Subject: Re: [PATCH v3 1/3] mfd: intel-m10-bmc: rename the local variables

On Sat, 25 Jun 2022, Tom Rix wrote:

> 
> On 6/24/22 2:22 AM, Tianfei Zhang wrote:
> > It had better use ddata for local variables which
> > directly interacts with dev_get_drvdata()/dev_set_drvdata().
> 
> This is a cleanup, not related to the patchset, it should be split from the
> patchset.

So long as they're contained in their own patch, clean-ups are fine.

-- 
Lee Jones [李琼斯]
Principal Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog