linux-kernel - Re: [PATCH v7 5/5] mtd: rawnand: meson: not support legacy clock

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <af10ff7f-b9e7-7bdc-a5ba-855b891f1110@amlogic.com>
Date:   Mon, 27 Jun 2022 10:36:54 +0800
From:   Liang Yang <liang.yang@...ogic.com>
To:     Neil Armstrong <narmstrong@...libre.com>,
        Miquel Raynal <miquel.raynal@...tlin.com>,
        <linux-mtd@...ts.infradead.org>
CC:     kernel test robot <lkp@...el.com>,
        Rob Herring <robh+dt@...nel.org>,
        Richard Weinberger <richard@....at>,
        Vignesh Raghavendra <vigneshr@...com>,
        Jerome Brunet <jbrunet@...libre.com>,
        Martin Blumenstingl <martin.blumenstingl@...glemail.com>,
        Kevin Hilman <khilman@...libre.com>,
        Jianxin Pan <jianxin.pan@...ogic.com>,
        Victor Wan <victor.wan@...ogic.com>,
        XianWei Zhao <xianwei.zhao@...ogic.com>,
        Kelvin Zhang <kelvin.zhang@...ogic.com>,
        BiChao Zheng <bichao.zheng@...ogic.com>,
        YongHui Yu <yonghui.yu@...ogic.com>,
        <linux-arm-kernel@...ts.infradead.org>,
        <linux-amlogic@...ts.infradead.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v7 5/5] mtd: rawnand: meson: not support legacy clock

Hi Neil,

On 2022/6/24 21:27, Neil Armstrong wrote:
> [ EXTERNAL EMAIL ]
> 
> Hi,
> 
> On 24/06/2022 15:12, Liang Yang wrote:
>> meson NFC driver use common clock interfaces. so the test robot report
>> some errors once using the legacy clock with HAVE_LEGACY_CLK on.
>>
>> Reported-by: kernel test robot <lkp@...el.com>
>> Signed-off-by: Liang Yang <liang.yang@...ogic.com>
>> ---
>>   drivers/mtd/nand/raw/Kconfig | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/mtd/nand/raw/Kconfig b/drivers/mtd/nand/raw/Kconfig
>> index 67b7cb67c030..0ff86ca5932d 100644
>> --- a/drivers/mtd/nand/raw/Kconfig
>> +++ b/drivers/mtd/nand/raw/Kconfig
>> @@ -395,7 +395,7 @@ config MTD_NAND_STM32_FMC2
>>   config MTD_NAND_MESON
>>       tristate "Support for NAND controller on Amlogic's Meson SoCs"
>> -    depends on ARCH_MESON || COMPILE_TEST
>> +    depends on ARCH_MESON || COMPILE_TEST || COMMON_CLK
> 
> This should be :
>      depends on COMMON_CLK && (ARCH_MESON || COMPILE_TEST)

ok, i will fix it. thanks.

> 
>>       select MFD_SYSCON
>>       help
>>         Enables support for NAND controller on Amlogic's Meson SoCs.
> 
> Neil
> 
> .