linux-kernel - Re: [PATCH] media: Fix incorrect P010 chroma order description

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YrltXpTYqMZK/AZV@pendragon.ideasonboard.com>
Date:   Mon, 27 Jun 2022 11:42:06 +0300
From:   Laurent Pinchart <laurent.pinchart@...asonboard.com>
To:     Sebastian Fricke <sebastian.fricke@...labora.com>
Cc:     linux-media@...r.kernel.org, kernel@...labora.com,
        Mauro Carvalho Chehab <mchehab@...nel.org>,
        Hans Verkuil <hverkuil-cisco@...all.nl>,
        Ezequiel Garcia <ezequiel@...guardiasur.com.ar>,
        Sakari Ailus <sakari.ailus@...ux.intel.com>,
        Ricardo Ribalda <ribalda@...omium.org>,
        Andrzej Pietrasiewicz <andrzej.p@...labora.com>,
        Daniel Scally <djrscally@...il.com>,
        Sergey Senozhatsky <senozhatsky@...omium.org>,
        Nicolas Dufresne <nicolas.dufresne@...labora.com>,
        Benjamin Gaignard <benjamin.gaignard@...labora.com>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] media: Fix incorrect P010 chroma order description

Hi Sebastian,

Thank you for the patch.

On Mon, Jun 27, 2022 at 09:12:23AM +0200, Sebastian Fricke wrote:
> The chroma order of P010 is `CbCr`,
> match with the descriptions in `include/uapi/linux/videodev2.h` and the
> documentation.
> 
> Fixes: 5374d8fb75f31 Add P010 video format

This should be

Fixes: 5374d8fb75f3 ("media: Add P010 video format")

I recommend adding the following to your ~/.gitconfig:

[pretty]
	fixes = Fixes: %h (\"%s\")

You can then use `git show --pretty=fixes -s` to generate the right
Fixes: tag. If you fix lots of bugs, an alias in your ~/.bashrc is also
useful:

gpf() {
	git show --pretty=fixes -s ${1:-HEAD} | xclip -selection clipboard
}

> Signed-off-by: Sebastian Fricke <sebastian.fricke@...labora.com>

Reviewed-by: Laurent Pinchart <laurent.pinchart+renesas@...asonboard.com>

> ---
>  drivers/media/v4l2-core/v4l2-ioctl.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/media/v4l2-core/v4l2-ioctl.c b/drivers/media/v4l2-core/v4l2-ioctl.c
> index e2526701294e..e03362c8aef9 100644
> --- a/drivers/media/v4l2-core/v4l2-ioctl.c
> +++ b/drivers/media/v4l2-core/v4l2-ioctl.c
> @@ -1306,7 +1306,7 @@ static void v4l_fill_fmtdesc(struct v4l2_fmtdesc *fmt)
>  	case V4L2_PIX_FMT_NV61:		descr = "Y/CrCb 4:2:2"; break;
>  	case V4L2_PIX_FMT_NV24:		descr = "Y/CbCr 4:4:4"; break;
>  	case V4L2_PIX_FMT_NV42:		descr = "Y/CrCb 4:4:4"; break;
> -	case V4L2_PIX_FMT_P010:		descr = "10-bit Y/CrCb 4:2:0"; break;
> +	case V4L2_PIX_FMT_P010:		descr = "10-bit Y/CbCr 4:2:0"; break;
>  	case V4L2_PIX_FMT_NV12_4L4:	descr = "Y/CbCr 4:2:0 (4x4 Linear)"; break;
>  	case V4L2_PIX_FMT_NV12_16L16:	descr = "Y/CbCr 4:2:0 (16x16 Linear)"; break;
>  	case V4L2_PIX_FMT_NV12_32L32:   descr = "Y/CbCr 4:2:0 (32x32 Linear)"; break;

-- 
Regards,

Laurent Pinchart