linux-kernel - Re: [PATCH v2 7/8] dma-buf: remove useless FMODE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Yrl6nTFibUS7xISn@zx2c4.com>
Date:   Mon, 27 Jun 2022 11:38:37 +0200
From:   "Jason A. Donenfeld" <Jason@...c4.com>
To:     linux-kernel@...r.kernel.org, viro@...iv.linux.org.uk,
        Jens Axboe <axboe@...nel.dk>, linux-fsdevel@...r.kernel.org,
        Sumit Semwal <sumit.semwal@...aro.org>,
        dri-devel@...ts.freedesktop.org,
        Christian König <christian.koenig@....com>
Subject: Re: [PATCH v2 7/8] dma-buf: remove useless FMODE_LSEEK flag

Hi Daniel,

On Mon, Jun 27, 2022 at 11:08:32AM +0200, Daniel Vetter wrote:
> On Sat, Jun 25, 2022 at 01:01:14PM +0200, Jason A. Donenfeld wrote:
> > This is already set by anon_inode_getfile(), since dma_buf_fops has
> > non-NULL ->llseek, so we don't need to set it here too.
> > 
> > Suggested-by: Al Viro <viro@...iv.linux.org.uk>
> > Cc: Sumit Semwal <sumit.semwal@...aro.org>
> > Cc: Christian König <christian.koenig@....com>
> > Cc: dri-devel@...ts.freedesktop.org
> > Signed-off-by: Jason A. Donenfeld <Jason@...c4.com>
> 
> I'm assuming this is part of a vfs cleanup and lands through that tree?
> For that:
> 
> Acked-by: Daniel Vetter <daniel.vetter@...ll.ch>

With the exception of the first patch (which is more urgent), yes, that
is my assumption too.

Jason