linux-kernel - Re: [PATCH v2] earlycon: prevent multiple register

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2386f29173c6a6d31e3e07630a44eafb@walle.cc>
Date:   Tue, 28 Jun 2022 13:21:23 +0200
From:   Michael Walle <michael@...le.cc>
To:     Rob Herring <robh+dt@...nel.org>,
        Frank Rowand <frowand.list@...il.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Jiri Slaby <jirislaby@...nel.org>
Cc:     devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-serial@...r.kernel.org
Subject: Re: [PATCH v2] earlycon: prevent multiple register_console()

Hi,

Am 2022-06-02 11:00, schrieb Michael Walle:
> If the earlycon parameter is given twice, the kernel will spit out a
> WARN() in register_console() because it was already registered. The
> non-dt variant setup_earlycon() already handles that gracefully. The dt
> variant of_setup_earlycon() doesn't. Add the check there and add the
> -EALREADY handling in early_init_dt_scan_chosen_stdout().
> 
> FWIW, this doesn't happen if CONFIG_ACPI_SPCR_TABLE is set. In that 
> case
> the registration is delayed until after earlycon parameter(s) are
> parsed.
> 
> Signed-off-by: Michael Walle <michael@...le.cc>

Ping :) Or do I have to resend this patch?

-michael