linux-kernel - Re: [PATCH] drivers/net/usb/r8152: Enable MAC address passthru support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <d7c3ce9f-d144-0083-162b-448570f2b5e5@suse.com>
Date:   Tue, 28 Jun 2022 13:26:40 +0200
From:   Oliver Neukum <oneukum@...e.com>
To:     Andrew Lunn <andrew@...n.ch>,
        Franklin Lin <franklin_lin@...tron.corp-partner.google.com>
Cc:     edumazet@...gle.com, kuba@...nel.org, pabeni@...hat.com,
        linux-usb@...r.kernel.org, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org, davem@...emloft.net,
        franklin_lin@...tron.com
Subject: Re: [PATCH] drivers/net/usb/r8152: Enable MAC address passthru
 support



On 28.06.22 12:17, Andrew Lunn wrote:
> On Tue, Jun 28, 2022 at 09:53:25AM +0800, Franklin Lin wrote:
>> From: franklin_lin <franklin_lin@...tron.corp-partner.google.com>
>>
>> Enable the support for providing a MAC address
>> for a dock to use based on the VPD values set in the platform.
> 
> Maybe i'm missing it, but i don't see any code which verifies this
> r8152 is actually in the dock, and not a USB ethernet dongle plugged
> into some port of either the laptop or the dock itself.

And it will happily assign the same MAC to multiple devices.
I am afraid this patch needs some basic redesign.

	Regards
		Oliver