linux-kernel - Re: [PATCH 06/10] iio: adc: mcp3911: add support for oversampling ratio

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHp75VfPMjx8ACN-8xTwJsuYWoM1yHToPGSC=2R8TH5hgR3=-A@mail.gmail.com>
Date:   Tue, 28 Jun 2022 13:56:30 +0200
From:   Andy Shevchenko <andy.shevchenko@...il.com>
To:     Marcus Folkesson <marcus.folkesson@...il.com>
Cc:     Kent Gustavsson <kent@...oris.se>,
        Jonathan Cameron <jic23@...nel.org>,
        Lars-Peter Clausen <lars@...afoo.de>,
        Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        linux-iio <linux-iio@...r.kernel.org>,
        devicetree <devicetree@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 06/10] iio: adc: mcp3911: add support for oversampling ratio

On Fri, Jun 24, 2022 at 2:07 PM Marcus Folkesson
<marcus.folkesson@...il.com> wrote:
> On Thu, Jun 23, 2022 at 09:20:01PM +0200, Andy Shevchenko wrote:
> > On Thu, Jun 23, 2022 at 9:08 PM Marcus Folkesson
> > <marcus.folkesson@...il.com> wrote:

...

> > > +static const int mcp3911_osr_table[] = {32, 64, 128, 256, 512, 1024, 2048, 4096};
> >
> > Spaces inside {}.
>
> Not sure what you mean?

   int foo = { 1, 2, 3 };

...

> > > +               ret = mcp3911_update(adc, MCP3911_REG_CONFIG,
> > > +                               MCP3911_CONFIG_OSR,
> > > +                               val, 2);
> >
> > sizeof() ?
>
> sizeof() what?

sizeof(val) ?

-- 
With Best Regards,
Andy Shevchenko