linux-kernel - RE: [PATCH 04/14] KVM: VMX: Extend VMX controls macro shenanigans

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87edz9uhak.fsf@redhat.com>
Date:   Tue, 28 Jun 2022 14:02:59 +0200
From:   Vitaly Kuznetsov <vkuznets@...hat.com>
To:     "Dong, Eddie" <eddie.dong@...el.com>,
        "kvm@...r.kernel.org" <kvm@...r.kernel.org>,
        Paolo Bonzini <pbonzini@...hat.com>,
        "Christopherson, Sean" <seanjc@...gle.com>
Cc:     Anirudh Rayabharam <anrayabh@...ux.microsoft.com>,
        Wanpeng Li <wanpengli@...cent.com>,
        Jim Mattson <jmattson@...gle.com>,
        Maxim Levitsky <mlevitsk@...hat.com>,
        "linux-hyperv@...r.kernel.org" <linux-hyperv@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH 04/14] KVM: VMX: Extend VMX controls macro shenanigans

"Dong, Eddie" <eddie.dong@...el.com> writes:

>> -----Original Message-----
>> From: Vitaly Kuznetsov <vkuznets@...hat.com>
>> Sent: Monday, June 27, 2022 9:05 AM
>> To: kvm@...r.kernel.org; Paolo Bonzini <pbonzini@...hat.com>;
>> Christopherson,, Sean <seanjc@...gle.com>
>> Cc: Anirudh Rayabharam <anrayabh@...ux.microsoft.com>; Wanpeng Li
>> <wanpengli@...cent.com>; Jim Mattson <jmattson@...gle.com>; Maxim
>> Levitsky <mlevitsk@...hat.com>; linux-hyperv@...r.kernel.org; linux-
>> kernel@...r.kernel.org
>> Subject: [PATCH 04/14] KVM: VMX: Extend VMX controls macro shenanigans
>> 
>> When VMX controls macros are used to set or clear a control bit, make sure
>> that this bit was checked in setup_vmcs_config() and thus is properly
>> reflected in vmcs_config.
>> 

...

>
> With this, will it be safer if we present L1 CTRL MSRs with the bits
> KVM really uses? Do I miss something?

Sean has already answered but let me present my version. Currently,
vmcs_config has sanitized VMX control MSRs values filtering out three
groups of features:
- Features, which KVM doesn't know about.
- Features, which KVM can't enable (because of eVMCS, bugs,...)
- Features, which KVM doesn't want to enable for some reason.
L1 VMX control MSRs should have the first two groups filtered out but
not the third. E.g. when EPT is in use, KVM doesn't use
CPU_BASED_CR3_LOAD_EXITING/CPU_BASED_CR3_STORE_EXITING but this doesn't
mean that all possible L1 hypervisors are going to be happy if we filter
these out. Same goes to e.g. CPU_BASED_RDTSC_EXITING: KVM never sets
this for itself but nested hypervisor can.

-- 
Vitaly