[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Message-ID: <20220628131259.3109124-1-yangyingliang@huawei.com>
Date: Tue, 28 Jun 2022 21:12:59 +0800
From: Yang Yingliang <yangyingliang@...wei.com>
To: <linux-kernel@...r.kernel.org>, <netdev@...r.kernel.org>,
<linux-renesas-soc@...r.kernel.org>
CC: <clement.leger@...tlin.com>, <olteanv@...il.com>,
<f.fainelli@...il.com>, <davem@...emloft.net>
Subject: [PATCH -next v2] net: pcs-rzn1-miic: fix return value check in miic_probe()
On failure, devm_platform_ioremap_resource() returns a ERR_PTR() value
and not NULL. Fix return value checking by using IS_ERR() and return
PTR_ERR() as error value.
Fixes: 7dc54d3b8d91 ("net: pcs: add Renesas MII converter driver")
Reported-by: Hulk Robot <hulkci@...wei.com>
Signed-off-by: Yang Yingliang <yangyingliang@...wei.com>
---
v2:
change commit message as Clément suggested.
---
drivers/net/pcs/pcs-rzn1-miic.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/pcs/pcs-rzn1-miic.c b/drivers/net/pcs/pcs-rzn1-miic.c
index 8f5e910f443d..d896961e48cc 100644
--- a/drivers/net/pcs/pcs-rzn1-miic.c
+++ b/drivers/net/pcs/pcs-rzn1-miic.c
@@ -461,8 +461,8 @@ static int miic_probe(struct platform_device *pdev)
spin_lock_init(&miic->lock);
miic->dev = dev;
miic->base = devm_platform_ioremap_resource(pdev, 0);
- if (!miic->base)
- return -EINVAL;
+ if (IS_ERR(miic->base))
+ return PTR_ERR(miic->base);
ret = devm_pm_runtime_enable(dev);
if (ret < 0)
--
2.25.1
Powered by blists - more mailing lists