linux-kernel - [asahilinux:t8112/bringup 11/12] drivers/iommu/apple-dart.c:1075:78: error: macro "DART_TCR" requires 2 arguments, but only 1 given

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <202206282105.M1v2vJso-lkp@intel.com>
Date:   Tue, 28 Jun 2022 21:29:15 +0800
From:   kernel test robot <lkp@...el.com>
To:     Hector Martin <marcan@...can.st>
Cc:     kbuild-all@...ts.01.org, linux-kernel@...r.kernel.org
Subject: [asahilinux:t8112/bringup 11/12] drivers/iommu/apple-dart.c:1075:78:
 error: macro "DART_TCR" requires 2 arguments, but only 1 given

tree:   https://github.com/AsahiLinux/linux t8112/bringup
head:   18558a69178b03776aaea0f2aca1d6299f07f8b9
commit: c803ba31378e39254cbe8bbe384ab1757cf8a14e [11/12] iommu: dart: Support different variants with different registers
config: sparc64-randconfig-r012-20220627
compiler: sparc64-linux-gcc (GCC) 11.3.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/AsahiLinux/linux/commit/c803ba31378e39254cbe8bbe384ab1757cf8a14e
        git remote add asahilinux https://github.com/AsahiLinux/linux
        git fetch --no-tags asahilinux t8112/bringup
        git checkout c803ba31378e39254cbe8bbe384ab1757cf8a14e
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.3.0 make.cross W=1 O=build_dir ARCH=sparc64 SHELL=/bin/bash drivers/iommu/

If you fix the issue, kindly add following tag where applicable
Reported-by: kernel test robot <lkp@...el.com>

All errors (new ones prefixed by >>):

   drivers/iommu/apple-dart.c: In function 'apple_dart_suspend':
>> drivers/iommu/apple-dart.c:1075:78: error: macro "DART_TCR" requires 2 arguments, but only 1 given
    1075 |                 dart->save_tcr[sid] = readl_relaxed(dart->regs + DART_TCR(sid));
         |                                                                              ^
   drivers/iommu/apple-dart.c:87: note: macro "DART_TCR" defined here
      87 | #define DART_TCR(dart, sid) ((dart)->hw->tcr + ((sid) << 2))
         | 
>> drivers/iommu/apple-dart.c:1075:66: error: 'DART_TCR' undeclared (first use in this function)
    1075 |                 dart->save_tcr[sid] = readl_relaxed(dart->regs + DART_TCR(sid));
         |                                                                  ^~~~~~~~
   drivers/iommu/apple-dart.c:1075:66: note: each undeclared identifier is reported only once for each function it appears in
   drivers/iommu/apple-dart.c: In function 'apple_dart_resume':
   drivers/iommu/apple-dart.c:1100:78: error: macro "DART_TCR" requires 2 arguments, but only 1 given
    1100 |                 writel_relaxed(dart->save_tcr[sid], dart->regs + DART_TCR(sid));
         |                                                                              ^
   drivers/iommu/apple-dart.c:87: note: macro "DART_TCR" defined here
      87 | #define DART_TCR(dart, sid) ((dart)->hw->tcr + ((sid) << 2))
         | 
   drivers/iommu/apple-dart.c:1100:66: error: 'DART_TCR' undeclared (first use in this function)
    1100 |                 writel_relaxed(dart->save_tcr[sid], dart->regs + DART_TCR(sid));
         |                                                                  ^~~~~~~~


vim +/DART_TCR +1075 drivers/iommu/apple-dart.c

7d276300914820 Sven Peter    2021-11-02  1067  
166fb0f3ea44cf Hector Martin 2022-03-05  1068  #ifdef CONFIG_PM_SLEEP
166fb0f3ea44cf Hector Martin 2022-03-05  1069  static int apple_dart_suspend(struct device *dev)
166fb0f3ea44cf Hector Martin 2022-03-05  1070  {
166fb0f3ea44cf Hector Martin 2022-03-05  1071  	struct apple_dart *dart = dev_get_drvdata(dev);
166fb0f3ea44cf Hector Martin 2022-03-05  1072  	unsigned int sid, idx;
166fb0f3ea44cf Hector Martin 2022-03-05  1073  
a47ec020cc1bdb Hector Martin 2022-06-28  1074  	for (sid = 0; sid < dart->num_streams; sid++) {
166fb0f3ea44cf Hector Martin 2022-03-05 @1075  		dart->save_tcr[sid] = readl_relaxed(dart->regs + DART_TCR(sid));
1a7bf1b831b1bd Hector Martin 2022-06-28  1076  		for (idx = 0; idx < dart->hw->ttbr_count; idx++)
166fb0f3ea44cf Hector Martin 2022-03-05  1077  			dart->save_ttbr[sid][idx] =
1a7bf1b831b1bd Hector Martin 2022-06-28  1078  				readl_relaxed(dart->regs + DART_TTBR(dart, sid, idx));
166fb0f3ea44cf Hector Martin 2022-03-05  1079  	}
166fb0f3ea44cf Hector Martin 2022-03-05  1080  
166fb0f3ea44cf Hector Martin 2022-03-05  1081  	return 0;
166fb0f3ea44cf Hector Martin 2022-03-05  1082  }
166fb0f3ea44cf Hector Martin 2022-03-05  1083  

:::::: The code at line 1075 was first introduced by commit
:::::: 166fb0f3ea44cf9c21905123bdae0ae1e2e70300 iommu: dart: Add suspend/resume support

:::::: TO: Hector Martin <marcan@...can.st>
:::::: CC: Janne Grunau <j@...nau.net>

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp

View attachment "config" of type "text/plain" (159186 bytes)