linux-kernel - Re: [PATCH 13/22] drm: scheduler: add a missing kernel-doc parameter

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CADnq5_PAW_et564Sjt7HvQwnqcMyzukc3paeU-pWPMKRM55DMA@mail.gmail.com>
Date:   Tue, 28 Jun 2022 10:42:05 -0400
From:   Alex Deucher <alexdeucher@...il.com>
To:     Mauro Carvalho Chehab <mchehab@...nel.org>
Cc:     Linux Doc Mailing List <linux-doc@...r.kernel.org>,
        Jonathan Corbet <corbet@....net>,
        Mauro Carvalho Chehab <mchehab+huawei@...nel.org>,
        LKML <linux-kernel@...r.kernel.org>,
        Maling list - DRI developers 
        <dri-devel@...ts.freedesktop.org>, David Airlie <airlied@...ux.ie>
Subject: Re: [PATCH 13/22] drm: scheduler: add a missing kernel-doc parameter

On Tue, Jun 28, 2022 at 5:46 AM Mauro Carvalho Chehab
<mchehab@...nel.org> wrote:
>
> Add a description for struct device at drm_sched_init(), in order
> to solve this warning:
>
>         drivers/gpu/drm/scheduler/sched_main.c:999: warning: Function parameter or member 'dev' not described in 'drm_sched_init'
>
> Signed-off-by: Mauro Carvalho Chehab <mchehab@...nel.org>

Generally in the drm tree we use / rather than : in the patch titles.  E.g.,

drm/scheduler: add a missing kernel-doc parameter

With that fixed:
Reviewed-by: Alex Deucher <alexander.deucher@....com>


> ---
>
> To avoid mailbombing on a large number of people, only mailing lists were C/C on the cover.
> See [PATCH 00/22] at: https://lore.kernel.org/all/cover.1656409369.git.mchehab@kernel.org/
>
>  drivers/gpu/drm/scheduler/sched_main.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/scheduler/sched_main.c b/drivers/gpu/drm/scheduler/sched_main.c
> index 76fd2904c7c6..b45bd8473e9e 100644
> --- a/drivers/gpu/drm/scheduler/sched_main.c
> +++ b/drivers/gpu/drm/scheduler/sched_main.c
> @@ -987,6 +987,7 @@ static int drm_sched_main(void *param)
>   *             used
>   * @score: optional score atomic shared with other schedulers
>   * @name: name used for debugging
> + * @dev: pointer to struct device
>   *
>   * Return 0 on success, otherwise error code.
>   */
> --
> 2.36.1
>