linux-kernel - Re: [PATCH] dt-bindings: chosen: document rng-seed property

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 28 Jun 2022 17:26:45 +0200
From:   Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To:     "Jason A. Donenfeld" <Jason@...c4.com>,
        Hsin-Yi Wang <hsinyi@...omium.org>
Cc:     robh@...nel.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org,
        Jonathan Neuschäfer <j.neuschaefer@....net>,
        Kees Cook <keescook@...omium.org>,
        Geert Uytterhoeven <geert@...ux-m68k.org>,
        Will Deacon <will@...nel.org>,
        Florian Fainelli <f.fainelli@...il.com>
Subject: Re: [PATCH] dt-bindings: chosen: document rng-seed property

On 28/06/2022 17:23, Jason A. Donenfeld wrote:
> Hi Hsin-Yi,
> 
> On Tue, Jun 28, 2022 at 11:39:38AM +0800, Hsin-Yi Wang wrote:
>> On Mon, Jun 27, 2022 at 11:21 PM Jason A. Donenfeld <Jason@...c4.com> wrote:
>>>
>>> Document the /chosen/rng-seed property, which has existed for quite some
>>> time but without an entry in this file.
>>>
>>> Fixes: 428826f5358c ("fdt: add support for rng-seed")
>>> Cc: Hsin-Yi Wang <hsinyi@...omium.org>
>>> Cc: Kees Cook <keescook@...omium.org>
>>> Cc: Rob Herring <robh@...nel.org>
>>> Cc: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
>>> Reported-by: Geert Uytterhoeven <geert@...ux-m68k.org>
>>> Signed-off-by: Jason A. Donenfeld <Jason@...c4.com>
>>> ---
>> It's currently documented in
>> https://github.com/devicetree-org/dt-schema/blob/main/dtschema/schemas/chosen.yaml
>>
>> https://lore.kernel.org/lkml/CAL_Jsq+uSdk9YNbUW35yjN3q8-3FDobrxHmBpy=4RKmCfnB0KQ@mail.gmail.com/
> 
> Well, let's see. That email says:
> 
>> Already documented here[1]. I've been meaning to delete chosen.txt so
>> that's a bit more obvious.
>>
>> I realize it's a bit harder to find what's documented where. Long term
>> we'd like to generate documentation from the schema and integrate as
>> part of the spec. Short term, it would be quite trivial to make a 'am
>> I documented' utility.
> 
> That sounds reasonable. But when was that email written? April 2, 2020.
> That's 817 days ago.

817 days And the field is documented, so nothing to do here regarding
"rng-seed".


> So I call BS on this being a continued justification for rejecting this
> patch (which apparently was submitted by Florian over two years ago
> too). 

Because patch is not needed and is already done....

> Rob clearly hasn't followed through.

You got there link to repo, what do you need more to follow? Remove the
chosen.txt? Sure - submit a separate patch.

>  So please apply this patch so
> that chosen.txt remains maintained.

Instead submit a patch removing it. There is no particular point to
duplicate bindings and dt-schema is the core here, the main one.

> 
> Later if he moves forward with his plan, then no harm done, since the
> file will be deleted anyway.
> 
> Sometimes it's best to reassess things based on the reality of the
> situation, you know?


Best regards,
Krzysztof