linux-kernel - Re: [PATCH -next] usb: musb: mpfs: add missing clk_disable_unprepare() in mpfs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1bdbd6a6-2bd1-cd03-b710-ced9f44cbaff@microchip.com>
Date:   Tue, 28 Jun 2022 16:57:30 +0000
From:   <Conor.Dooley@...rochip.com>
To:     <yangyingliang@...wei.com>, <linux-kernel@...r.kernel.org>,
        <linux-usb@...r.kernel.org>, <linux-riscv@...ts.infradead.org>
CC:     <Conor.Dooley@...rochip.com>,
        <Valentina.FernandezAlanis@...rochip.com>,
        <gregkh@...uxfoundation.org>
Subject: Re: [PATCH -next] usb: musb: mpfs: add missing
 clk_disable_unprepare() in mpfs_remove()



On 28/06/2022 15:05, Yang Yingliang wrote:
> clock source is prepared and enabled by clk_prepare_enable()
> in probe function, but no disable or unprepare in remove.
> 
> Fixes: 7a96b6ea90a4 ("usb: musb: Add support for PolarFire SoC's musb controller")
> Reported-by: Hulk Robot <hulkci@...wei.com>
> Signed-off-by: Yang Yingliang <yangyingliang@...wei.com>
> ---
>  drivers/usb/musb/mpfs.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/usb/musb/mpfs.c b/drivers/usb/musb/mpfs.c
> index a69ca338eace..cea2e8108867 100644
> --- a/drivers/usb/musb/mpfs.c
> +++ b/drivers/usb/musb/mpfs.c
> @@ -239,6 +239,7 @@ static int mpfs_remove(struct platform_device *pdev)
>  {
>  	struct mpfs_glue *glue = platform_get_drvdata(pdev);
>  
> +	clk_disable_unprepare(glue->clk);
>  	platform_device_unregister(glue->musb);
>  	usb_phy_generic_unregister(pdev);
>  

I'll file this one under "obviously correct".
Reviewed-by: Conor Dooley <conor.dooley@...rochip.com>
Thanks!